Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Disables pipe gas visuals for now #650

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24264

About The Pull Request

Pipe gas visuals are suspected to have been possibly contributing to a recent asset loading issue so we were discussing disabling them, for the time being.

Additionally the colors tend to not blend how you'd expect them to, so in practice the visuals are not very useful in their current state unfortunately.

Maybe when some of the issues around them have been addressed we can re-enable this, or make our own changes to the system potentially. It's still in the code, just disabled for now.

Proof of Testing

Back to non-fancy pipes

image

Changelog

🆑 vinylspiders
del: pipe gas visuals have been disabled for the time being
/:cl:

* Disables pipe gas visuals

* Update datum_pipeline.dm

* Update pipes.dm

---------

Co-authored-by: GoldenAlpharex <[email protected]>
@Iajret Iajret merged commit 5228acc into master Nov 16, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24264 branch November 16, 2023 09:08
AnywayFarus added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants