[MIRROR] Adjusts BS Miner with a new updated overlay, slightly better code, and less annoying buzzing/beeping #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d less annoying buzzing/beeping (#25008) * this * oop * I do actually miss the sounds ever so slightly * Still too much, silence you fool * Moved this here * Update modular_skyrat/modules/bluespace_miner/code/bluespace_miner.dm Co-authored-by: Bloop <[email protected]> * Update modular_skyrat/modules/bluespace_miner/code/bluespace_miner.dm Co-authored-by: Bloop <[email protected]> * Update modular_skyrat/modules/bluespace_miner/code/bluespace_miner.dm Co-authored-by: Bloop <[email protected]> * Update modular_skyrat/modules/bluespace_miner/code/bluespace_miner.dm Co-authored-by: Bloop <[email protected]> * Update modular_skyrat/modules/bluespace_miner/code/bluespace_miner.dm Co-authored-by: Bloop <[email protected]> --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 16, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 28, 2024
* Remove unneeded 'a' from swabbing message. (#81118) ## About The Pull Request When using the biopsy tool on something that doesn't have a swabbing result it would say: > "You do not manage to find a anything on [target]!". The "find a anything on [target]" is incorrect and reads off, so this pr just changes the respective statement in `code/datums/components/swabbing.dm` to remove that a, becoming: > "You do not manage to find anything on [target]!". ## Why It's Good For The Game Minor grammar fix. ## Changelog :cl: spellcheck: You no longer fail to find "a anything" when swabbing something for cytology that doesn't have swabbing results. /:cl: * Remove unneeded 'a' from swabbing message. --------- Co-authored-by: _0Steven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25008
About The Pull Request
Mechanically, nothing has changed. It works exactly the same as before, except now it also has lights to show you why it's not working. And the sound is no longer obnoxiously loud with a range of 17 and passing walls
The first light lights up red when something is wrong.
The second and third light signal if atmos is not working, being either crimson (Pressure high) or teal (Pressure low)
Fourth light lights up orange when temp is high
All lights will light up red when too close to another miner
How This Contributes To The Skyrat Roleplay Experience
You will no longer have to hear an earpiercing buzz when standing near engineering or atmos.
Proof of Testing
Have tested this already to prove that mechanically nothing has changed, images of extra stuff provided
Screenshots/Videos
Here it is complaining about low pressure and high heatFunctioning state stayed untouched
High pressure
Too close
Changelog
🆑 Majkl-J
qol: Bluespace miner now has visual indication to its status and problem
sound: The sound on the bluespace miner is no longer earpiercingly loud
image: Added lights to the bluespace miner
refactor: Refactored bluespace miner code
/:cl: