[MIRROR] Fixes to the Galactic Material Market regarding market quantity. #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity. [MDB IGNORE] (#25022) * Fixes to the Galactic Material Market regarding market quantity. (#79307) ## About The Pull Request This PR makes a fix to market quantity of materials on the GMM. In short, when you buy sheets, they get removed from the market's pool of available resources. When buying resources, they now shift up and down based on a fraction of their inherent base_market_quantity, and not their current quantity, preventing situations where a material can fully deplete all its stock forever. I've also tweaked the numbers to try and keep those changes from swinging too far wide as a result of this change. Respecting quantity of materials should additionally help to decrease the quantity of bike rounds in-game as well as the rare but horrifying billion credit round. ## Why It's Good For The Game Respecting quantity of materials should additionally help to decrease the quantity of bike rounds in-game as well as the rare but horrifying billion credit round. Also, I namely just completely missed this during the original PR and I've been out of state for a few weeks so I've been meaning to get around to fixing this. Fixes #79116. Fixes #79247. ## Changelog :cl: fix: The Galactic Material Market now respects quantity of materials purchased, removing them from the market when bought and preventing you from ordering more than are available at a given time. /:cl: --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com> * Fixes to the Galactic Material Market regarding market quantity. --------- Co-authored-by: ArcaneMusic <[email protected]> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 18, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 28, 2024
* Emergency shuttle console only works on the shuttle (#81123) ## About The Pull Request Fixes tgstation/tgstation#79067 where you can hijack the shuttle without actually being on the shuttle. ## Changelog :cl: LT3 fix: Emergency shuttle console now only works while on the emergency shuttle /:cl: * Emergency shuttle console only works on the shuttle --------- Co-authored-by: lessthanthree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25022
Original PR: tgstation/tgstation#79307
About The Pull Request
This PR makes a fix to market quantity of materials on the GMM. In short, when you buy sheets, they get removed from the market's pool of available resources.
When buying resources, they now shift up and down based on a fraction of their inherent base_market_quantity, and not their current quantity, preventing situations where a material can fully deplete all its stock forever. I've also tweaked the numbers to try and keep those changes from swinging too far wide as a result of this change.
Respecting quantity of materials should additionally help to decrease the quantity of bike rounds in-game as well as the rare but horrifying billion credit round.
Why It's Good For The Game
Respecting quantity of materials should additionally help to decrease the quantity of bike rounds in-game as well as the rare but horrifying billion credit round. Also, I namely just completely missed this during the original PR and I've been out of state for a few weeks so I've been meaning to get around to fixing this.
Fixes #79116. Fixes #79247.
Changelog
🆑 ArcaneMusic
fix: The Galactic Material Market now respects quantity of materials purchased, removing them from the market when bought and preventing you from ordering more than are available at a given time.
/:cl: