[MIRROR] Changes Nanotrasen Consultant and Blueshield's ID trims to be limited while preventing self-service AA #5277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4602
About The Pull Request
Nanotrasen Consultant and Blueshield's ID trims have been changed to be limited, meaning that the amount of access that can be given are as limited as a head's.
I've also removed the ID change access from the NTC since, well, that's HoP's job rather than an advisor's.
Additionally prevents those with captain access only (NTCs and Blueshields) from doing self-service AA by giving themselves HoP and then doing whatever they want with it.
Code mostly borrowed from Bubber
How This Contributes To The Nova Sector Roleplay Experience
Makes the game respect the game design behind the ID card trims where only captain's spare and captain's ID have the ability to be given all access as well as the following;
Command policy already states that blueshields already aren't meant to give themselves access, but that does not necessarily stop them if they know how to be sneaky enough and don't get ahelped. It's also hard to tell on whenever they have AA or not until an admin varedits their ID closely which is kind of annoying to do so. There are already many, many ways for them to break into places during emergencies and even then, they are still better off following the heads on emergencies like a bodyguard is meant to do.
NTCs in the other hand essentially have semi-AA already, which is enough to inspect every department well while doing their job on advising command. If they have a reason to require more access (eg. Departments breaking SoP) they should consult the HoP or Captain for it.
Additionally, the block encourages both roles to interact with the HoP or Captain in case they need access change rather than self-servicing AA for themselves, we're a roleplay server after all and veterans are meant to be a good representative of that, rather than bypassing the HoP entirely by just opening Plexagon Access Management on their PDA and ticking every single box just because the game allows that.
Proof of Testing
Screenshots/Videos
Tested, NTCs only really get access to modify service while Blueshields are locked out of it
NTC's limited access
Both IDs seen from a HoP ID
Changelog
🆑 Hardly
balance: Nanotrasen Consultants and Blueshields now use limited ID trims
balance: Blueshields and Nanotrasen Consultants can no longer change their own access
/:cl: