Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Changes Nanotrasen Consultant and Blueshield's ID trims to be limited while preventing self-service AA #5277

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4602

About The Pull Request

Nanotrasen Consultant and Blueshield's ID trims have been changed to be limited, meaning that the amount of access that can be given are as limited as a head's.

I've also removed the ID change access from the NTC since, well, that's HoP's job rather than an advisor's.

Additionally prevents those with captain access only (NTCs and Blueshields) from doing self-service AA by giving themselves HoP and then doing whatever they want with it.

Code mostly borrowed from Bubber

How This Contributes To The Nova Sector Roleplay Experience

Makes the game respect the game design behind the ID card trims where only captain's spare and captain's ID have the ability to be given all access as well as the following;

Command policy already states that blueshields already aren't meant to give themselves access, but that does not necessarily stop them if they know how to be sneaky enough and don't get ahelped. It's also hard to tell on whenever they have AA or not until an admin varedits their ID closely which is kind of annoying to do so. There are already many, many ways for them to break into places during emergencies and even then, they are still better off following the heads on emergencies like a bodyguard is meant to do.

NTCs in the other hand essentially have semi-AA already, which is enough to inspect every department well while doing their job on advising command. If they have a reason to require more access (eg. Departments breaking SoP) they should consult the HoP or Captain for it.

Additionally, the block encourages both roles to interact with the HoP or Captain in case they need access change rather than self-servicing AA for themselves, we're a roleplay server after all and veterans are meant to be a good representative of that, rather than bypassing the HoP entirely by just opening Plexagon Access Management on their PDA and ticking every single box just because the game allows that.

Proof of Testing

Screenshots/Videos

Tested, NTCs only really get access to modify service while Blueshields are locked out of it

image

NTC's limited access

Jui3059tvB

Both IDs seen from a HoP ID

8uXDgIrvkl

SGQkRfCowD

Changelog

🆑 Hardly
balance: Nanotrasen Consultants and Blueshields now use limited ID trims
balance: Blueshields and Nanotrasen Consultants can no longer change their own access
/:cl:

Hardly3D and others added 2 commits January 7, 2025 07:15
… while preventing self-service AA (#4602)

* Changes NTC and BS's trim

* And encourages them to interact with the HoP

* A better solution (thanks deadmon)

* Update modular_nova/master_files/code/datums/id_trim/jobs.dm

Whoops

Co-authored-by: FlufflesTheDog <[email protected]>

* Update modular_nova/master_files/code/datums/id_trim/jobs.dm

Co-authored-by: FlufflesTheDog <[email protected]>

* oop

---------

Co-authored-by: FlufflesTheDog <[email protected]>
…e limited while preventing self-service AA
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Nova Mirror Balance labels Jan 7, 2025
@FeenieRU FeenieRU merged commit 8c3223d into master Jan 8, 2025
29 checks passed
AnywayFarus added a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Nova Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants