[MIRROR] Gun safety on deathmatch and bitdomains are off by default #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update gun.dm * Update gun.dm * Update gun.dm * Alternative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4616
About The Pull Request
Adds a check that turns the gun safety to off if it was spawned in a reserved z level such as deathmatch and vr, transits were coded to be excluded.
How This Contributes To The Nova Sector Roleplay Experience
Gun safety is fine for anywhere else, except it eventually becomes annoying in deathmatch and bitdomains since you're meant to go out, guns blazing in both of them and sometimes juggling between guns a lot in which depending on the map or domain it turns becomes a race to turn the safety off before you can shoot each other.
I don't expect this to affect bitrunner and SNPC RP much, either side are still able to turn the gun safety back on if they wish.
Proof of Testing
Tested in deathmatch and bitrunning, as well as spawning on station. Only known issue is spawned SNPCs, guns and deathmatch loadouts always having them on but trying
Screenshots/Videos
Bitrunning
Changelog
🆑 Hardly
qol: Guns in deathmatch and bitdomains now have gun safety set to off by default.
/:cl: