Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes ears getting sprites they shouldn't be getting when they're set to not having visuals #5234

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4641

About The Pull Request

Apparently some synths and slime people could accidentally be getting ear sprites when they weren't supposed to. This aims to fix that, by ensuring that ears are imprinted whenever provided by the wardrobe subsystem, because we can't always be certain that the sprite is always going to be the same, unlike /tg/'s assumption.

How This Contributes To The Nova Sector Roleplay Experience

Less characters with wrong ear overlays == more better roleplay 👍

Proof of Testing

Screenshots/Videos These were taken right after one-another. With ears turned on:

image

With ears turned off:

image

Changelog

🆑 GoldenAlpharex
fix: Synths and slimefolks should no longer be getting weird ears suddenly growing on their heads overnight, and should properly get the ears (or lack thereof) they rightfully deserve from their genetics (or whatever the equivalent of genetics is for synthetic beings... Blueprints?).
/:cl:

GoldenAlpharex and others added 2 commits December 14, 2024 00:22
… to not having visuals (#4641)

* Fixes ears getting sprites they shouldn't be getting when they're set to not having visuals

* Swap this to enter_wardrobe

---------

Co-authored-by: Fluffles <[email protected]>
@FeenieRU FeenieRU merged commit bada536 into master Dec 14, 2024
33 checks passed
AnywayFarus added a commit that referenced this pull request Dec 14, 2024
@Iajret Iajret deleted the upstream-mirror-4641 branch December 21, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants