Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Tweaks to Bitrunning SNPC spawners (and some other things) (but without TGS DMAPI) #5223

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4615

About The Pull Request

Most importantly, this allows SNPCs to select their characters' appearance on spawn in Syndicate Assault and Island Brawl domains; also tweaks their ID card name showing up for this to be more impactful.
Syndicate Assault's SNPCs' names show up as their bitrunning aliases; Island Brawl's are their normal names.
Pirate Cove SNPC became a skeleton with a pirate name, with the aforementioned issue also tackled.
As for the other things:
MilSim's DLC disk's marksman loadout has been changed to give out throwing knives instead of having invisibility.
Adds a new gear disk to bitrunning for a cheap 250 point price, loaded with a disposable NIF implanter as well as a Special Vending Machine.

How This Contributes To The Nova Sector Roleplay Experience

I reckon that being able to play as oneself should be permitted to both sides; to hopefully generate more player interactions and whatnot, especially if they'll become flavored more properly.
Bug fixes good, even if incredibly minor.
I've always felt that the marksman, -generalist-, loadout was underwhelming and not that impactful compared to the other ones. This could very well remain the case even after the adjustment, yet the ability to theoretically counter cyberpolice via embedding knives would probably be appreciated by the players.
As for the LustWish and NIFs...
All of this is a thinly veiled excuse to ERP as a Bitrunner to be absolutely honest but uh who cares.

Proof of Testing

Screenshots/Videos

image
image
image

Changelog

🆑 Stalkeros
add: New bitrunning disk, allowing you to either install a single-use NIF, or summon a Very Interesting Vending Machine.
add: MilSim DLC disk's Marksman was granted infinite supplies of throwing knives and a sonar at the cost of invisibility.
qol: You can now join as your own character in the Syndicate Assault and Island Brawl domains.
fix: Names should show up on Syndicate Assault, Pirate Cove, and Island Brawl IDs once again.
/:cl:

Stalkeros2 and others added 2 commits December 12, 2024 01:39
…ut TGS DMAPI) (#4615)

* recap

* Update tgstation.dme

* Oh I forgot about that

---------

Co-authored-by: Bloop <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Nova Mirror Feature Fix Quality of Life labels Dec 11, 2024
@Iajret Iajret merged commit 0a7c4a9 into master Dec 12, 2024
28 checks passed
@Iajret Iajret deleted the upstream-mirror-4615 branch December 12, 2024 16:17
AnywayFarus added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Fix Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Nova Mirror Quality of Life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants