Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix oversized stomachs and implants being dropped on spawn #5189

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4622

About The Pull Request

Oversized stomachs used the return value of Insert to check if something was actually inserted, which isn't valid anymore (and never used to return anything but true)

And loadout implants just don't care what they're replacing, so things like charging implants get dropped on the ground if overwritten

How This Contributes To The Nova Sector Roleplay Experience

bugn't

Proof of Testing

Screenshots/Videos

image
Pictured: A large robot dog observing a lack of organs on their arrival seat. Convenient!

Changelog

🆑 FlufflesTheDog
fix: stomachs no longer drop out of oversized characters on spawn
fix: charging implants no longer drop out of synth characters on spawn
/:cl:

FlufflesTheDog and others added 2 commits November 24, 2024 15:07
* fix organs being dropped when they shouldn't be

* runtimes-b-gone

.Insert will forcemove organs to the human's loc when removed, which
runtimes on preview characters.

Surely that's the only time characters will be in nullspace right guys?
right?
@FeenieRU FeenieRU merged commit bfc3fc4 into master Nov 24, 2024
32 checks passed
AnywayFarus added a commit that referenced this pull request Nov 24, 2024
@Iajret Iajret deleted the upstream-mirror-4622 branch December 21, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants