Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Port of "Fix niche bitrunner avatar name bug and make net avatar ID take on avatar name" (but without TGS DMAPI) #5186

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4613

About The Pull Request

See tgstation/tgstation#87879 for more information.
Tin; bitrunner names no longer override the crew manifest.

How This Contributes To The Nova Sector Roleplay Experience

Fixes jank.
It's nicer to have the IDs use the actual names rather than being generic.

Proof of Testing

Screenshots/Videos

image
image
image

Changelog

🆑 Stalkeos, 00-Steven
fix: A bitrunner avatar spawning with the exact same name as a name currently on the records no longer updates that record to match when the hacker alias gets applied.
qol: Net avatar ID cards use the net avatar's name instead of being generic.
/:cl:

Stalkeros2 and others added 2 commits November 21, 2024 16:01
…ake on avatar name" (but without TGS DMAPI) (#4613)

Update avatar_connection.dm
…atar ID take on avatar name" (but without TGS DMAPI)
@FeenieRU FeenieRU merged commit 00a1edc into master Nov 21, 2024
33 checks passed
AnywayFarus added a commit that referenced this pull request Nov 21, 2024
@Iajret Iajret deleted the upstream-mirror-4613 branch December 21, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants