[MIRROR] [MODULAR] Add: Ethereal & Synthetic Music Synthesizer #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Ethereal discharger synth action * Rename ethereal_instrument module to ethereal_synth * Cleaning up UI issues, added Emag effect * Add singing action to synth species * Add emag_act proc to synth species * Remove ui_close call that didnt do jack * Fix typo * Add suggestions from review, add efficient species loss handler * Fix unregistersignal to account for other signal * Add species perks * Add extra details to readme * Cleaning up * Fix typo, fix missing signal handler macros, cleaning up * Fix typo * Update modular_nova/modules/species_synthesizer/sing_tones.dm --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4531
About The Pull Request
This PR adds an action to Ethereal and Synthetic species that allows them to use an internal music synthesizer; it requires
/obj/item/organ/internal/tongue/etherealto function. Instruments are limited to "spaceman", "meowsynth", "square wave", "sine wave", and "saw wave"; emagging adds "honk".Granular Change List
species_synthesizer, containing/datum/action/sing_tones.modular_nova/master_files/code/modules/mob/living/carbon/human/species_type/ethereal.dm:/datum/species/ethereal/on_species_gain()to add the action to the mob./datum/species/ethereal/create_pref_unique_perks()to add the "Musical Discharger" species perk.modular_nova/modules/synths/code/species/synthetic.dm:/datum/species/synthetic/on_species_gain()to add the action to the mob./datum/species/synthetic/create_pref_unique_perks()to add the "Tone Synthesizer" species perk.How This Contributes To The Nova Sector Roleplay Experience
Adds a bit of unique flair to Synthetic and Ethereal species by giving them an internal music synthesizer. The synthesizer instruments are limited to "spaceman", "meowsynth", "square wave", "sine wave", and "saw wave". The "honk" instrument is added upon emagging.
Proof of Testing
Fully tested!
Screenshots/Videos
dreamseeker_IyxN7WNnpU.mp4
dreamseeker_U7uOMvqFM1.mp4
Changelog
🆑 A.C.M.O.
add: Added a music synthesizer action to Ethereal and Synthetic species.
/:cl: