[MIRROR] Forged Weapons Bane list expanded and span made it clear what they do. #5131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4515) * Forged Weapons Bane list expanded and span made it clear what they do. * Apply suggestions from code review --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4515
About The Pull Request
Gives Bane to Legions on the reagent weapons (They dont have the beast mob type despite the Legion adds do, go figure!)
Gives Reagent weapons a text that says they do double damage against beasts and monsters.
How This Contributes To The Nova Sector Roleplay Experience
It makes the feature more consistent and informs people that use them and didnt read 3 month old changelogs whats going on, so its not a secret feature.
Proof of Testing
Screenshots/Videos
minor change, its tested locally.Changelog
🆑 OrbisAnima
qol: Reagent weapons now properly say when examined they do double damage against beasts and monsters.
balance: Reagent weapons now do double damage against legions
/:cl: