[MIRROR] Brings back saltpetre to upgraded chem dispensers. #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4417
About The Pull Request
This PR brings back saltpetre to upgraded chem dispensers. It's meant to have saltpetre in upgraded dispensers, but a very-likely accidental omission since the days of the rodent made it so saltpetre was missing. I don't think it's gone for gameplay reasons, given how saltpetre is able to be made using 3 base ingredients that are already present. Base former(?)-upstream code has saltpetre in the list of upgraded reagents. If maintainers think this isn't a fix and was intended behavior then they can change the labels.
Also this changes the lists to have trailing commas as per the proper code style guide.
How This Contributes To The Nova Sector Roleplay Experience
It kinda doesn't? It's a gameplay bug fix, not a roleplay addition. Still, bug fixes are nice and having saltpetre on demand is convenient for any advanced botanical needs.
Proof of Testing
With and without upgrades.
Without UpgradesWith Upgrades
Changelog
🆑 CRITAWAKETS
fix: After several years of its mistaken lacking, saltpetre is back in upgraded chemical dispensers.
/:cl: