[MIRROR] Limits plumbing reaction chamber ph balance attempts #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s [MDB IGNORE] (#24721) * [NO GBP] Limits plumbing reaction chamber ph balance attempts (#79429) ## About The Pull Request - Fixes #79427 It's not a memory leak but a dedicated while loop that will run as many times as required to accurately balance the ph of the solution. Sometimes it makes way too many attempts causing high tick usage. Now the loop will run for a maximum of 5 times before giving up preventing lag. I decided 5 because that should be sufficient for most cases but it can be adjusted later by anyone interested by changing the value of the `MAX_PH_ADJUSTMENTS` define ## Changelog :cl: fix: plumbing reaction chamber will attempt to balance the ph of the solution a maximum of 5 times before giving up and thus preventing infinite loops, high tick usage /:cl: * [NO GBP] Limits plumbing reaction chamber ph balance attempts --------- Co-authored-by: SyncIt21 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 2, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Adds a Debug command to stop all weather. * Update admin_verbs.dm --------- Co-authored-by: ArcaneMusic <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24721
Original PR: tgstation/tgstation#79429
About The Pull Request
It's not a memory leak but a dedicated while loop that will run as many times as required to accurately balance the ph of the solution. Sometimes it makes way too many attempts causing high tick usage. Now the loop will run for a maximum of 5 times before giving up preventing lag.
I decided 5 because that should be sufficient for most cases but it can be adjusted later by anyone interested by changing the value of the
MAX_PH_ADJUSTMENTSdefineChangelog
🆑 SyncIt21
fix: plumbing reaction chamber will attempt to balance the ph of the solution a maximum of 5 times before giving up and thus preventing infinite loops, high tick usage
/:cl: