[MIRROR] You cannot store ammo casings (individual bullets) and ammo boxes (like magazines) in your suit storage #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…boxes (like magazines) in your suit storage [MDB IGNORE] (#24691) * You cannot store ammo casings (individual bullets) and ammo boxes (like magazines) in your suit storage (#79311) ## About The Pull Request What it says on the tin. ## Why It's Good For The Game A) This messes with hotkey muscle memory quite significantly. Unless you have something in suit storage when you go to put a magazine back into your other storage (like your belt), you may accidentally place it into your suit storage. B) This may be why people think magnetic holsters are bad/don't work. Operatives sometimes hotswap half clips, and what might happen during a particularly intense combat is that they inadvertently put the magazine they just pulled from their gun into their suit storage because they're hotkeying; denying them their magnetic holster's major upside. Snapping their guns back into their storage and away from prying assistant hands. C) It serves no tactical purpose to put a bullet into your suit storage over the gun itself. Priority should always be to the belt storage. ## Changelog :cl: qol: To avoid poor magazine discipline, most combat-ready personnel have instructed _not_ to put magazines into the gun loops on their armor vests. /:cl: * You cannot store ammo casings (individual bullets) and ammo boxes (like magazines) in your suit storage --------- Co-authored-by: necromanceranne <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 1, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 9, 2024
…80818) (#375) Fixes Cameras views on clients 515.1615 or greater (#80818) ## About The Pull Request Fixes tgstation/tgstation#79954 Turns out the cause of cameras breaking was something weird with how Byond determined the CENTER location for screen_locs on secondary popup maps like cameras and the spyglass. This can be remedied by manually using the LEFT,TOP position for the plane relays. However LEFT,TOP breaks the views for clients 1614 and below so I included a jank solution that should allow any client up to this point have the screen displayed correctly ### 515.1609 views working  ### 515.1623 views working  ## Why It's Good For The Game Cameras working passed 1614 means you can update the server. At some point I suspect Lummox will fix the CENTER position on secondary maps and when that happens it will likely break the current fix. ## Changelog :cl: fix: popup screen locs will work on clients >1614. Security cameras and Spyglass will work /:cl: --------- Co-authored-by: Chubbygummibear <[email protected]> Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: LemonInTheDark <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Jan 9, 2024
…80818) (#375) (#1505) Fixes Cameras views on clients 515.1615 or greater (#80818) ## About The Pull Request Fixes tgstation/tgstation#79954 Turns out the cause of cameras breaking was something weird with how Byond determined the CENTER location for screen_locs on secondary popup maps like cameras and the spyglass. This can be remedied by manually using the LEFT,TOP position for the plane relays. However LEFT,TOP breaks the views for clients 1614 and below so I included a jank solution that should allow any client up to this point have the screen displayed correctly ### 515.1609 views working  ### 515.1623 views working  ## Why It's Good For The Game Cameras working passed 1614 means you can update the server. At some point I suspect Lummox will fix the CENTER position on secondary maps and when that happens it will likely break the current fix. ## Changelog :cl: fix: popup screen locs will work on clients >1614. Security cameras and Spyglass will work /:cl: --------- Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: Chubbygummibear <[email protected]> Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: LemonInTheDark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24691
Original PR: tgstation/tgstation#79311
About The Pull Request
What it says on the tin.
Why It's Good For The Game
A) This messes with hotkey muscle memory quite significantly. Unless you have something in suit storage when you go to put a magazine back into your other storage (like your belt), you may accidentally place it into your suit storage.
B) This may be why people think magnetic holsters are bad/don't work. Operatives sometimes hotswap half clips, and what might happen during a particularly intense combat is that they inadvertently put the magazine they just pulled from their gun into their suit storage because they're hotkeying; denying them their magnetic holster's major upside. Snapping their guns back into their storage and away from prying assistant hands.
C) It serves no tactical purpose to put a bullet into your suit storage over the gun itself. Priority should always be to the belt storage.
Changelog
🆑 necromanceranne
qol: To avoid poor magazine discipline, most combat-ready personnel have instructed not to put magazines into the gun loops on their armor vests.
/:cl: