[MIRROR] Sorts the modular skirts_dresses.dm file, properly subtypes the new Medium/Long skirts and fixes their broken toggleability #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edium/Long skirts and fixes their broken toggleability (#24680) * moves the dresses to the dress section, skirts to the skirt section * Repaths the new skirts to actually be skirt subtypes (and removes their chest coverage)
AnywayFarus
added a commit
that referenced
this pull request
Nov 1, 2023
ReezeBL
pushed a commit
that referenced
this pull request
Jan 9, 2024
… when placed down (#369) (#1498) yeah Co-authored-by: Paxilmaniac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#24680
About The Pull Request
Title
1 - The file was a mess. The point of the comments // SKIRTS // and // DRESSES // was kind of... not followed. So I moved the skirts to skirts, and dresses to dresses.
2 - The new medium/long skirts were base types of under and so had a few issues being caused by being entirely new items. Now they're subtypes of dress/skirt/skyrat as they should have been
3 - The above means that the skirts now no longer are Toggleable by default. They HAVE no toggle state, so being toggleable just made them into an error sprite.
-Other changes include: Slightly tweaked descriptions, and the two skirts no longer covering Chests
How This Contributes To The Skyrat Roleplay Experience
Bug fixies
Proof of Testing
Screenshots/Videos
Skirt still works.
And loadout still works
Changelog
🆑 OrionTheFox
fix: fixed the Medium/Long Skirts incorrectly being Toggleable, and falsely covering the Chest
/:cl: