[MIRROR] Dehardcodes microwave cleaning, allows spray cleaner to work on dense objects such as windows #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on dense objects such as windows [MDB IGNORE] (#24684) * Dehardcodes microwave cleaning, allows spray cleaner to work on dense objects such as windows (#79354) - Dehardcodes microwave cleaning - Instead of hard istyping for a rag, soap, or space cleaner, we just use `wash`. - Gets rid of a redundant signal - `COMSIG_ATOM_WASHED`: not only was it misleading (only sent to items), but it was pointless because `COMSIG_COMPONENT_CLEAN_ACT` is the same signal. - Improves microwave attackby code, splitting tool stuff into tool-procs - Allows spray cleaner to work on dense objects such as windows - Clicking on a dense object or mob adjacent to you with spray cleaner will spawn the puff cloud on the target, rather than on your own position. - This will skip the moveloop and just clean everything on the target turf alone. - This means you can spray down a bloody window with a spray bottle, as janitor gods intended. - It also means you can fill the spray with other stuff to spray onto dense objects directly, which might be worth noting. Especially for stuff like Napalm. Fixes #79261 Opens up the sandbox to allow more objects to clean microwaves + better code. :cl: Melbert qol: Clicking on an adjacent dense object (or mob) with Spray Cleaner will now spritz it rather than doing nothing. This means you can use Spray Cleaner to clean bloodied windows, as the janitor gods intended. It also means you can fill a spray bottle with Napalm, I guess. refactor: Any cleaning object can now clean a microwave. /:cl: * Dehardcodes microwave cleaning, allows spray cleaner to work on dense objects such as windows --------- Co-authored-by: MrMelbert <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-24684
AnywayFarus
added a commit
that referenced
this pull request
Oct 31, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 8, 2024
… li ke 600 times a life tick or something (#366) * Cache heretic delusion icon so it doesn't call `getFlatIcon` li ke 600 times a life tick or something (#80842) Heretic's weeping painting causes everyone who sees it to hallucinate everyone else as heretics. So it caused this hallucination every 5 life ticks. Which means every 5 life ticks it would call GFI for every mob in view. And like everyone on the station would get this effect. So everyone on the station is now hallucinating every mob in view is a heretic and it's calling GFI every time. So yeah we should probably cache this. * Cache heretic delusion icon so it doesn't call `getFlatIcon` li ke 600 times a life tick or something --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24684
Original PR: tgstation/tgstation#79354
About The Pull Request
Dehardcodes microwave cleaning
wash.Gets rid of a redundant signal
COMSIG_ATOM_WASHED: not only was it misleading (only sent to items), but it was pointless becauseCOMSIG_COMPONENT_CLEAN_ACTis the same signal.Improves microwave attackby code, splitting tool stuff into tool-procs
Allows spray cleaner to work on dense objects such as windows
Fixes #79261
Why It's Good For The Game
Opens up the sandbox to allow more objects to clean microwaves + better code.
Changelog
🆑 Melbert
qol: Clicking on an adjacent dense object (or mob) with Spray Cleaner will now spritz it rather than doing nothing. This means you can use Spray Cleaner to clean bloodied windows, as the janitor gods intended. It also means you can fill a spray bottle with Napalm, I guess.
refactor: Any cleaning object can now clean a microwave.
/:cl: