[MIRROR] Rephrases advisory level descriptions #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rephrases advisory level descriptions (#82585)
## About The Pull Request
Some of the station alert descriptions contained grammatical errors.
This PR corrects some word choice, punctuation, and grammar mistakes as
well as editing some sections for clarity. For example, Pulsar Star's
current warning
> "Your sector's advisory level is Pulsar Star. A large unknown
electromagnetic field has stormed through nearby surveillance equipment.
No surveillance data has been able to be obtained showing no credible
threats to Nanotrasen assets within the Spinward Sector. The Department
advises maintaining high alert against potential threats, regardless of
a lack of information."
has been changed to
> "Your sector's advisory level is Pulsar Star. A large, unknown
electromagnetic field has stormed through nearby surveillance equipment
causing major data loss. Partial data was recovered and showed no
credible threats to Nanotrasen assets within the Spinward Sector;
however, the Department of Intelligence advises maintaining high alert
against potential threats due to the lack of complete data."
## Why It's Good For The Game
Readability is important
## Changelog
:cl:
spellcheck: grammar fixes in the roundstart advisory warnings
/:cl:
---------
Co-authored-by: MrMelbert <[email protected]>
* Rephrases advisory level descriptions
---------
Co-authored-by: Horatio22 <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 12, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 5, 2024
…of invoking runes until a minute after being released [MDB IGNORE] (#2847) * Cultist shades no longer count as cultists for the purposes of invoking runes until a minute after being released (#83487) ## About The Pull Request The following was made in response to a discussion overheard during the coderbus roundtable. Cult shades can no longer contribute to cultist rune invoking until they've been released from their soulstone from over a minute. If placed in a shell, they can properly invoke runes and assist you with converts/summoning as normal. This also moves around some files/code related to cultist antag datums. Datum stuff is now in its own subfolder of the cultist folder in the antagonists module.  I hated testing this. ## Why It's Good For The Game This discourages the common practice of murdering and soulstoning another player, then keeping them as a shade in their backpack used only for invoking runes. This is, of course, incredibly unfun for the player who has been shaded, and encourages playing singleplayer cultist instead of with your teammates as a team antagonist. There are plenty of other ways to play singleplayer cultist. Create a summon rune, or put your shade in a shell. Carrying them around in your bag all round sucks. ## Changelog :cl: Rhials balance: cultist shades can no longer contribute to rune invocation until they've been out of their soulstone for a minute. Put them in a shell for God's sake! code: sweeps up cultist antag datum code into its own subfolder. code: cult shades now have their own antag datum. fix: constructs now properly clear the cultist antag datum and transfer the mind slightly earlier. /:cl: * Cultist shades no longer count as cultists for the purposes of invoking runes until a minute after being released --------- Co-authored-by: Rhials <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1931
Original PR: tgstation/tgstation#82585
About The Pull Request
Some of the station alert descriptions contained grammatical errors. This PR corrects some word choice, punctuation, and grammar mistakes as well as editing some sections for clarity. For example, Pulsar Star's current warning
has been changed to
Why It's Good For The Game
Readability is important
Changelog
🆑 Horatio22
spellcheck: grammar fixes in the roundstart advisory warnings
/:cl: