[MIRROR] General maintenance for chem master #2836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1904
Original PR: tgstation/tgstation#82002
About The Pull Request
1. Qol
2. Code Improvements
TARGET_BEAKER
,TARGET_BEAKER
etc. ther functionality is implemented as params in thetransfer_reagent()
proc directlyreagent_analysis_mode
,has_container_suggestion
etc. all memory savingsprintable_containers
now stores static values that can be shared across many chem masters3. Fixes
printing_amount
is now the maximum number of containers that can be printed at a time. Presently this number with upgraded parts would print out empty containers especially for patches. This is becausevolume_per_item
does not take into consideration this var. Also this var would not give control to the player on exactly how many containers to print as whatever amount the player entered would be multiplied with this value producing a lot of waste & worse empty containers. Now this var determines exactly how many containers you can print and is imposed on the client side UI as well4. Refactors (UI performance)
text2path()
cause its much fasterChangelog
🆑 SyncIt21
qol: Adds screen tips & examines for screwdriver, wrench, crowbar & beaker insertion, removal & replacing actions
qol: Analyzing reagents no longer blocks other players from doing other operations. Multiple players can analyze different reagents on the same machine
qol: You cannot do any tool acts on the machine while printing to prevent any side effects.
qol: The preferred container for the master reagent in the beaker is now showed in both condiment & chem master. The feature can be enabled/disabled via a check box
code: removed defines for reagent transfer, vars for reagent analyzis to save memory. Autodoc for other vars & procs
fix: You can hit the chem master with tools like screwdriver, crowbar, wrench & beaker in combat mode
fix: You cannot insert hologram items into the chem master
fix: Deconstructing a condiment master will give you the circuit board already pre-programmed with that option
fix: You now print the exact amount of containers requested even with upgraded parts without creating empty containers. Max printable containers is 13 with tier 4 parts able to print 50 containers.
refactor: Optimized client side UI code & chem master as a whole.
/:cl: