Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Autolathe computes custom material item print amounts correctly #2819

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1903
Original PR: tgstation/tgstation#82507

About The Pull Request

  • Fixes #82492

We find the maximum amount of material present to compute the print amount & not the minimum

Changelog

🆑 SyncIt21
fix: Autolathe correctly computes the print amount of custom material items like toolboxes and doesn't grey out its print button
/:cl:

…tly (#1903)

* Autolathe computes custom material item print amounts correctly (#82507)

## About The Pull Request
- Fixes #82492

We find the maximum amount of material present to compute the print
amount & not the minimum

## Changelog
:cl:
fix: Autolathe correctly computes the print amount of custom material
items like toolboxes and doesn't grey out its print button
/:cl:

* Autolathe computes custom material item print amounts correctly

---------

Co-authored-by: SyncIt21 <[email protected]>
@ReezeBL ReezeBL merged commit b08a990 into master Apr 10, 2024
26 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1903 branch April 10, 2024 21:53
AnywayFarus added a commit that referenced this pull request Apr 10, 2024
Iajret pushed a commit that referenced this pull request Jun 4, 2024
…he preferred brand (#2819)

* The memories for Smoker and Alcoholic now actually mention the preferred brand (#83674)

## About The Pull Request

This revises the descriptions for the smoker/alcoholic quirk memories to
actually mention the preferred brand:



## Why It's Good For The Game

Because memories should help you, well, remember stuff, and "Joe's
smoking problem" is kinda useless when you've forgotten _which_ brand
your character prefers.

`[name]'s smoking problem.` -> `[name]'s addiction to [preferred_brand]
cigarettes.`
`[name]'s drinking problem.` -> `[name]'s addiction to
[preferred_brandy] alcohol.`

## Changelog
:cl:
qol: The memories for Smoker and Alcoholic now actually mention the
preferred brand.
/:cl:

* The memories for Smoker and Alcoholic now actually mention the preferred brand

---------

Co-authored-by: Lucy <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
ReezeBL pushed a commit that referenced this pull request Jun 5, 2024
…he preferred brand (#2819) (#3633)

* The memories for Smoker and Alcoholic now actually mention the preferred brand (#83674)

## About The Pull Request

This revises the descriptions for the smoker/alcoholic quirk memories to
actually mention the preferred brand:



## Why It's Good For The Game

Because memories should help you, well, remember stuff, and "Joe's
smoking problem" is kinda useless when you've forgotten _which_ brand
your character prefers.

`[name]'s smoking problem.` -> `[name]'s addiction to [preferred_brand]
cigarettes.`
`[name]'s drinking problem.` -> `[name]'s addiction to
[preferred_brandy] alcohol.`

## Changelog
:cl:
qol: The memories for Smoker and Alcoholic now actually mention the
preferred brand.
/:cl:

* The memories for Smoker and Alcoholic now actually mention the preferred brand

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Lucy <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants