[MIRROR] [Modular] Fixes Telepathy quirk sending empty messages #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1894
About The Pull Request
This fixes the telepathy quirk specifically to not send an empty message if the user hits cancel, the x, or just enter with a empty message.
Before the tgui_text_imput didnt have its default value set to null. tgui_text_input sends that default value whenever the user hits the x or cancel. Without it it just becomes a empty string, which before was valid for the message to be sent to people.
This also checks now for if the message has a length of 0 and will refuse to send it too as its a empty message
How This Contributes To The Nova Sector Roleplay Experience
Less bugs, more indecisive psychics.
Proof of Testing
Screenshots/Videos
Hard for me to test by myself, as it requires to have two clients. I did test this change with a friend i just kinda forgot to record evidence, and don't wana pester them to rejoin my local server to test it more. It works and I have tested it
Changelog
🆑 SomeRandomOwl
fix: Telepathy quirk no longer sends empty messages on hitting the cancel button or closing the window.
/:cl: