[MIRROR] Update lead acid batteries charge values #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update lead acid batteries charge values (#82510) ## About The Pull Request So during the whole power consistency update thing, it seems lead acid batteries were entirely forgotten about. Which, well, is easy, because they never actually used `STANDARD_CELL_CHARGE`. https://github.com/tgstation/tgstation/blob/c34d56a45b0461f5e0fad3cc75e81580c3357119/code/game/objects/items/maintenance_loot.dm#L32-L33 Looking into it, the previous value for `STANDARD_CELL_CHARGE` seemed to have been 1000, so we convert it directly: ```dm maxcharge = STANDARD_CELL_CHARGE * 20 chargerate = STANDARD_CELL_CHARGE * 1.4 ``` But, comparing this to the normal power cells, it seems their charge rates got _halved_ during the update. So, we do that too. ```dm maxcharge = STANDARD_CELL_CHARGE * 20 chargerate = STANDARD_CELL_CHARGE * 0.7 ``` And that fixes it. ## Why It's Good For The Game Fixes lead acid batteries still using the old power amounts, and not being relative to `STANDARD_CELL_CHARGE`. ## Changelog :cl: fix: Lead acid batteries have had their power values fixed. /:cl: * Update lead acid batteries charge values --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 9, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 2, 2024
) * Borgs: the moduling (Various fixups to borg module code) * Update robot_upgrades.dm --------- Co-authored-by: Waterpig <[email protected]> Co-authored-by: Mal <[email protected]>
AnywayFarus
pushed a commit
that referenced
this pull request
Jun 2, 2024
) (#3602) * Borgs: the moduling (Various fixups to borg module code) * Update robot_upgrades.dm --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Waterpig <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1878
Original PR: tgstation/tgstation#82510
About The Pull Request
So during the whole power consistency update thing, it seems lead acid batteries were entirely forgotten about.
Which, well, is easy, because they never actually used
STANDARD_CELL_CHARGE.https://github.com/tgstation/tgstation/blob/c34d56a45b0461f5e0fad3cc75e81580c3357119/code/game/objects/items/maintenance_loot.dm#L32-L33
Looking into it, the previous value for
STANDARD_CELL_CHARGEseemed to have been 1000, so we convert it directly:But, comparing this to the normal power cells, it seems their charge rates got halved during the update.
So, we do that too.
And that fixes it.
Why It's Good For The Game
Fixes lead acid batteries still using the old power amounts, and not being relative to
STANDARD_CELL_CHARGE.Changelog
🆑 00-Steven
fix: Lead acid batteries have had their power values fixed.
/:cl: