[MIRROR] Pre-516 tgui prep #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pre-516 tgui prep (#82473) ## About The Pull Request This should be completely fine to run on our current servers. Moves the (massive) javascript out of tgui.html into its own file so I can lint/format/minify it Removes some of the checks for earlier versions of IE. No need to check for these now, especially not later Removes some pre-ie11 checks we're not using now Creates a fn to check if the user is running blink engine (chromium/edge) ## Why It's Good For The Game 516 prep * Pre-516 tgui prep --------- Co-authored-by: Jeremiah <[email protected]>
|
Make sure you test-merge NovaSector/NovaSector#1847 on your server, this apparently breaks some things. May want to avoid merging it entirely until it's fixed. |
Iajret
pushed a commit
that referenced
this pull request
May 31, 2024
* Fixes railings being invisible (#83584) Fixes #83575 Kinda my fault, I looked at tgstation/tgstation#83450, thought the railing code was weird and then forgot or something. I've reverted the changes and instead changed the map to not spawn walls on railings, which I probably should've done when I made the area :cl: fix: Fixes railings being invisible fix: Snow walls dont spawn on railings anymore in icebox /:cl: * Fixes railings being invisible --------- Co-authored-by: Time-Green <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1841
Original PR: tgstation/tgstation#82473
About The Pull Request
This should be completely fine to run on our current servers.
Moves the (massive) javascript out of tgui.html into its own file so I can lint/format/minify it
Removes some of the checks for earlier versions of IE. No need to check for these now, especially not later
Removes some pre-ie11 checks we're not using now
Creates a fn to check if the user is running blink engine (chromium/edge)
Why It's Good For The Game
516 prep