[MIRROR] Enable mech logging by default #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable mech logging by default (#82299) ## About The Pull Request Enables mech logging by default- this wasn't enabled by default when it was first introduced 6 years ago. These logfiles are tiny(In 1 terry round: 2kb mecha, 350kb game.txt), there is no reason to not have this enabled by default. ## Changelog :cl: config: mech logging is now on by default. Existing config setups will not mirror this change. /:cl: * Enable mech logging by default --------- Co-authored-by: Cyprex <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 5, 2024
Iajret
pushed a commit
that referenced
this pull request
May 29, 2024
* Make Watcher Wreath Bounties Completable (#83523) ## About The Pull Request Initial PR here: NovaSector/NovaSector#2694 This is a proposed fix for an issue reported downstream on NovaSector/NovaSector#2198 and requested to be put upstream where watcher wreath bounties were not accepting the items they state they want. The root of the issue seemed to be the FALSE flags attached to the wanted_types. include_subtypes can be used for what might have been the intended effect of having only ice wreaths for the ice bounty and normal wreaths for the normal bounty. ## Why It's Good For The Game This bug would prevent someone from being able to do any bounties until the 5 minute timer to refresh the bounty options passed. Less wait time on undoable tasks means more time spent interacting with the round. ## Changelog :cl: fix: fixed watcher wreath bounties being incompletable /:cl: * Make Watcher Wreath Bounties Completable --------- Co-authored-by: FearfulFurnishing <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 29, 2024
* Make Watcher Wreath Bounties Completable (#83523) ## About The Pull Request Initial PR here: NovaSector/NovaSector#2694 This is a proposed fix for an issue reported downstream on NovaSector/NovaSector#2198 and requested to be put upstream where watcher wreath bounties were not accepting the items they state they want. The root of the issue seemed to be the FALSE flags attached to the wanted_types. include_subtypes can be used for what might have been the intended effect of having only ice wreaths for the ice bounty and normal wreaths for the normal bounty. ## Why It's Good For The Game This bug would prevent someone from being able to do any bounties until the 5 minute timer to refresh the bounty options passed. Less wait time on undoable tasks means more time spent interacting with the round. ## Changelog :cl: fix: fixed watcher wreath bounties being incompletable /:cl: * Make Watcher Wreath Bounties Completable --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: FearfulFurnishing <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1763
Original PR: tgstation/tgstation#82299
About The Pull Request
Enables mech logging by default- this wasn't enabled by default when it was first introduced 6 years ago. These logfiles are tiny(In 1 terry round: 2kb mecha, 350kb game.txt), there is no reason to not have this enabled by default.
Changelog
🆑 Cyprex
config: mech logging is now on by default. Existing config setups will not mirror this change.
/:cl: