Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Make it easier to click on heretic influences #2696

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1759
Original PR: tgstation/tgstation#82375

About The Pull Request

This makes it so heretic influences are easier for heretics to click:

  • Clicking a codex cicatrix on the turf of an influence will let you the drain said influence, rather than having to click directly on the sprite
  • Any right click on the turf of an influence will be redirected to the influence. This really isn't as necessary as the first bit, but eh, why not, doesn't hurt.
butthole.mp4

Why It's Good For The Game

Way too easy to misclick the sprite due to the animation - last thing you want is to accidentally start drawing a rune when you're trying to sneakily drain a reality butthole.

Changelog

🆑 Absolucy
qol: Makes it easier for heretics to click on influences without accidentally drawing a rune with their codex cicatrix because the animation shifted and made you click on the floor instead.
/:cl:

* Make it easier to click on heretic influences (#82375)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This makes it so heretic influences are easier for heretics to click:
- Clicking a codex cicatrix on the turf of an influence will let you the
drain said influence, rather than having to click directly on the sprite
- Any right click on the turf of an influence will be redirected to the
influence. This really isn't as necessary as the first bit, but eh, why
not, doesn't hurt.




https://github.com/tgstation/tgstation/assets/65794972/124393a4-337d-49af-9f67-3e865e151aeb



## Why It's Good For The Game

Way too easy to misclick the sprite due to the animation - last thing
you want is to _accidentally start drawing a rune_ when you're trying to
sneakily drain a reality butthole.

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl:
qol: Makes it easier for heretics to click on influences without
accidentally drawing a rune with their codex cicatrix because the
animation shifted and made you click on the floor instead.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

* Make it easier to click on heretic influences

---------

Co-authored-by: Lucy <[email protected]>
@mogeoko mogeoko merged commit bfabf51 into master Apr 3, 2024
24 checks passed
@mogeoko mogeoko deleted the upstream-mirror-1759 branch April 3, 2024 16:21
AnywayFarus added a commit that referenced this pull request Apr 3, 2024
Iajret pushed a commit that referenced this pull request May 27, 2024
…lf Antag sound effect (#2696)

* Infected AI (Traitor Final Objective) no longer plays the Malf Antag sound effect (#83390)

## About The Pull Request
Does as title says. Infected AI *could* be given a new sound effect but
I'll leave that to someone in the future.

Also removes the ability for Infected AIs to set their own custom
objectives
## Why It's Good For The Game
Getting Malf AI usually means you can ignore laws. AIs really should be
checking their Law 0 before deciding to do their own flavor of chaos but
Infected AI having the same sound effect is an unnecessary extra chance
to mix the two up.
## Changelog
:cl:
qol: Traitor-created Infected AIs no longer hear the Malf AI antag sound
alert.
/:cl:

---------

Co-authored-by: Afevis <[email protected]>

* Infected AI (Traitor Final Objective) no longer plays the Malf Antag sound effect

---------

Co-authored-by: zxaber <[email protected]>
Co-authored-by: Afevis <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants