[MIRROR] Creates a node compatibility mode #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Creates a node compatibility mode (#82334) ## About The Pull Request By default this will install node v20 LTS, but if a user is detected to be using win 7 it's node v14 This lets us run higher node versions (with presumably more stable and performant content) while allowing win 7 users to play I should note that this is making clean tgui builds run at ~6.7sec which is about a 6.9% speed increase (nice) from the previous #80310 ## Why It's Good For The Game Better tools ## Changelog N/A nothing player facing * Creates a node compatibility mode --------- Co-authored-by: Jeremiah <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
May 27, 2024
…ted parts. (#2693) * Adds additional type logging to nested feedback for all printed parts. (#83466) ## About The Pull Request What it says on the tin, this adds logging to nested_logging for autolathes, protolathes, and the mech fabricator. Also quickly renames a variable name within the mech fabricator because this thing hasn't been updated in awhile and it was egregious to me. ## Why It's Good For The Game I wanted to throw together a quick superset chart of what items are printed most often and how often, and was shocked to learn that it wasn't logged in this way. It was recorded somewhat within the silo log, but this is MUCH easier to use all thing considered, so it's an easy fix. ## Changelog No front facing changes. * Adds additional type logging to nested feedback for all printed parts. --------- Co-authored-by: ArcaneMusic <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1752
Original PR: tgstation/tgstation#82334
About The Pull Request
By default this will install node v20 LTS, but if a user is detected to be using win 7 it's node v14
This lets us run higher node versions (with presumably more stable and performant content) while allowing win 7 users to play
I should note that this is making clean tgui builds run at ~6.7sec which is about a 6.9% speed increase (nice) from the previous #80310
Why It's Good For The Game
Better tools
Changelog
N/A nothing player facing