[MIRROR] Bumps dependencies.sh to 515.1633 Stable
#2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bumps `dependencies.sh` to 515.1633 Stable (#82138) ## About The Pull Request Two reasons for this. 1. It's the stable branch, so let's move it up. This PR will detect any issues that we might have with the latest 515.1633 as far as the codebase is concerned (the servers have been running 1633 for at least a week now). 2. ~~I'm fucking sick of seeing the Lua Scripting Notice in CI even though it was fixed a few days ago in #82074 (5624d9452413641b4c6d4b886cb116481186b8ac) ``~~ * Bumps `dependencies.sh` to 515.1633 Stable --------- Co-authored-by: san7890 <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
May 25, 2024
… `adminGreet()` (#2664) * Cleans up some admin-related stuff in client `Destroy()` and `adminGreet()` (#83427) ## About The Pull Request It made me really mad to see a huge list in the middle of client/Destroy for something that doesn't even run for 95% of users so I split it out into another proc so the fingerprint of the very important `Destroy()` stuff could be as minimal as possible without a big `pick()` so the server can send the "I need a man 🥺" message could be punted off to where no-one would care for it. It was already doing the async TGS operation so it doesn't matter anyways as far as proc overhead in my books. I also fixed up the code for `adminGreet()` as well because that was being really weird with not having proper booleans and running `pick()` on things with literally one value (as well as excess stringification)... it wasn't good so I just cleaned all that up too. Ideally this all means we take up a little less CPU time but the aim of this PR is to just clean it all up for modern coding standards. alphabetized lists and early returns galore. ## Why It's Good For The Game Code is better to read and less idented, and better yet it's no longer necessary to read all the softie messages in the middle of `Destroy()` ## Changelog Irrelevant * Cleans up some admin-related stuff in client `Destroy()` and `adminGreet()` --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1718
Original PR: tgstation/tgstation#82138
About The Pull Request
Two reasons for this.
I'm fucking sick of seeing the Lua Scripting Notice in CI even though it was fixed a few days ago in #82074 (5624d9452413641b4c6d4b886cb116481186b8ac)
