[MIRROR] General maintenance for reagent grinder #2625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1642
Original PR: tgstation/tgstation#82161
About The Pull Request
1. Qol
2. Code Improvements
attackby()
withitem_interaction()
so we can end the attack chain early for non combat operations like inserting beakers/ ingredients for grinding etc.Shake()
proc cause it did the same thingmapload
to see if we need the beaker to be created or not for round start reagent grindersoperate_for()
rather than having seperate procs for each operationTRAIT_MAY_CONTAIN_BLENDED_DUST
. Why do we have this? Its just used to change the grinder description to warn it may contain dust. It's a waste.3. Fixes
can_interact()
checks for using the UI & other stuffobj/item/grown
can be put from any bag into the grinder4. Refactors
🆑 SyncIt21
qol: adds examines & screentips for tool acts & other operations for reagent grinder
qol: adds an off icon for when the grinder panel is open/not powered
code: auto docs vars & procs. Shared common proc for grinding or juicing
code: removed trait for blended dust, changed some item interactions to end the attack chain early & save time
fix: no inserting hologram items into the reagent grinder
fix: you can hit the reagent grinder tools like screwdriver, wrench, crowbar & even beakers/ingredients etc when in combat mode
fix; adds sanity checks for when & how mobs interact with the reagent grinder
fix: examining a reagent grinder by an AI/Human with AI access now actually works.
fix: you can insert Nova flowers & other food items from any bag type
fix: reagent grinder now grinds all the contents of an item recursively to produce maximum reagents like a real grinder would
refactor: reagent grinder now measures available capacity to store items as total weight of stored items & not number. Capacity can be increased with upgraded matter bin
refactor: reagent grinder power usage is now a function of duration & total weight of items blended, meaining blending more number of items/larger items will consume more power
refactor: reagent grinder code has been optimized overall. Report bugs on github
/:cl: