[MIRROR] scanning export barcodes now tells you who made them and the profit split #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… profit split [MDB IGNORE] (#24563) * scanning export barcodes now tells you who made them and the profit split (#79173) ## About The Pull Request Scanning a parcel with an attached barcode, or the barcode itself, with a universal scanner, now actually tells you the owner of the associated bank account and the assigned profit-split. ## Why It's Good For The Game  ## Changelog :cl: qol: Universal scanners are now capable of recognizing the account owners and assigned profit splits on barcodes. Cargo technicians are asked to do their due diligence when matters call for it. /:cl: --------- Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com> Co-authored-by: Jacquerel <hnevard@ gmail.com> * scanning export barcodes now tells you who made them and the profit split --------- Co-authored-by: Hatterhat <[email protected]> Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com> Co-authored-by: Jacquerel <hnevard@ gmail.com>
AnywayFarus
added a commit
that referenced
this pull request
Oct 25, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Turbine code cleanup (#80637) ## About The Pull Request 1. Removed unused vars `our_turf_thermal_conductivity`. It did nothing 2. Removed redundant vars such as - `mapped` : It can be replaced with `maploaded` var inside `Initialize()` proc as it simply checks if the turbine was created during round start or not. This does mean that admin spawned turbine parts won't come pre installed with parts but that's not a big deal since they can spawn the parts anyway - `has_gas_mix` : All turbine parts set's this var to `TRUE` so might as well make that the default case - `gas_theoretical_volume` : This can be passed as an param inside `Initialize()` directly rather than storing it in a var which gets used only once 3. Autodoc for procs, fixed return values of some tool acts & `attackby`(we want to return TRUE to end the attack chain early). Removes balloon alert when opening/closing panel. The visual overlay makes that obvious 4. The turbine now shuts itself off when the room has no power/the turbine is sufficiently damaged. The turbine uses a small amount of power for operation (for that green light, internal electronics & stuff) cause it makes sense 5. Fixes runtime when opening turbine computer and one of the turbine parts is disconnected 6. Adds Screen tips & fixes examines (they weren't using the `span_notice()` proc) and adds even more examines ## Changelog :cl: fix: turbine now shuts itself off when the room apc loses power or if it gets damaged. Also uses a small amount of power for operation of internal electronics, the green light & other stuff fix: No more runtime in turbine computer when parts are not fully connected qol: adds screentips & examines for turbine code: removed unused vars, auto doc procs and cleans up some code in turbine /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com> * Turbine code cleanup --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24563
Original PR: tgstation/tgstation#79173
About The Pull Request
Scanning a parcel with an attached barcode, or the barcode itself, with a universal scanner, now actually tells you the owner of the associated bank account and the assigned profit-split.
Why It's Good For The Game
Changelog
🆑 Hatterhat
qol: Universal scanners are now capable of recognizing the account owners and assigned profit splits on barcodes. Cargo technicians are asked to do their due diligence when matters call for it.
/:cl: