Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds a var to determine if anomaly-locked MOD modules can have cores uninstalled #255

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24556
Original PR: tgstation/tgstation#79171

About The Pull Request

Title. The core_removable var on the anomaly_locked MOD module typepath now determines if a core can be removed post-installation. This isn't used anywhere, at the moment, but could be used to, say, prevent a space-loot MOD module's core from being removed for other purposes.

Adds /prebuilt/locked subtypes to the currently present and defined anomaly-locked modules, which have this var enabled, and puts them nowhere else.

image
image

Why It's Good For The Game

Another way to control distribution of anomaly cores - making people commit to having a limited-supply item installed in a thing, or something like that.

For habitual Github-readers, this is unused, at the moment, just something that could be used by another coder down the line or something.

Changelog

🆑 Hatterhat
add: Anomaly-locked MODsuit modules can now be varedited to have unremovable cores, or can be spawned with this functionality by using the /prebuilt/locked subtype.
/:cl:

…ve cores uninstalled [MDB IGNORE] (#24556)

* Adds a var to determine if anomaly-locked MOD modules can have cores uninstalled (#79171)

## About The Pull Request
Title. The `core_removable` var on the `anomaly_locked` MOD module
typepath now determines if a core can be removed post-installation. This
isn't used anywhere, at the moment, but could be used to, say, prevent a
space-loot MOD module's core from being removed for other purposes.

Adds `/prebuilt/locked` subtypes to the currently present and defined
anomaly-locked modules, which have this var enabled, and puts them
nowhere else.

![image](https://github.com/tgstation/tgstation/assets/31829017/af222175-7668-4e46-abab-5adf08be5d34)

![image](https://github.com/tgstation/tgstation/assets/31829017/4d6f4149-1227-4dd9-b368-7d55696fba92)

## Why It's Good For The Game
Another way to control distribution of anomaly cores - making people
commit to having a limited-supply item installed in a thing, or
something like that.

For habitual Github-readers, this is *unused*, at the moment, just
something that could be used by another coder down the line or
something.

## Changelog

:cl:
add: Anomaly-locked MODsuit modules can now be varedited to have
unremovable cores, or can be spawned with this functionality by using
the /prebuilt/locked subtype.
/:cl:

Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com>

* Adds a var to determine if anomaly-locked MOD modules can have cores uninstalled

---------

Co-authored-by: Hatterhat <[email protected]>
Co-authored-by: Hatterhat <Hatterhat@ users.noreply.github.com>
@ReezeBL ReezeBL merged commit 1ee2e1d into master Oct 25, 2023
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-24556 branch October 25, 2023 06:15
AnywayFarus added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants