[MIRROR] Pollution doesn't spawn when the subsystem is offline + only player-crafted bonfires produce smoke #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rafted bonfires produce smoke (#24555) * Pollution no longer happens when the subsystem is offline * Removes the code for bonfire pollution that wasn't done modularly * Modularizes bonfire pollution, makes the default bonfire not produce pollution * Player-made campfires produce pollution
AnywayFarus
added a commit
that referenced
this pull request
Oct 25, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Fixes list formatting in vox_sounds.dm (#80678) ## About The Pull Request The list formatting for these sounds got all messed up somehow. This just puts it in line with the code standards. ## Why It's Good For The Game I can look at this code without feeling mild despair ## Changelog N/A * Fixes list formatting in vox_sounds.dm --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#24555
About The Pull Request
It annoyed me that pollution would keep spawning even after the subsystem was turned off, so it won't do that anymore.
I also made it so only player-made bonfires would produce smoke, because otherwise it's a pain every time we have custom maps, or every time /tg/ adds a new thing with a bonfire in an enclosed area, which ends up smoking entire rooms/z-levels for zero gain.
How This Contributes To The Skyrat Roleplay Experience
Smoke will now only happen when it's meant to happen.
Proof of Testing
Screenshots/Videos
Changelog
🆑 GoldenAlpharex
fix: Pollution (smoke et al.) will no longer be added to turfs when the subsystem is offline. Basically, you can now turn off pollution properly.
qol: Only player-made bonfires will produce smoke.
/:cl: