Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes infinite loop in bitrunning #242

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24534
Original PR: tgstation/tgstation#79194

About The Pull Request

Clears up some functionality in netpod disconnect cases that lead to an infinite loop

Also fixes an errant message from #78959

Why It's Good For The Game

Fixes #79190

Changelog

🆑 jlsnow301
fix: Entering a virtual domain should no longer give you a message that it doesn't forbid items
/:cl:

* Fixes infinite loop in bitrunning (#79194)

## About The Pull Request
Clears up some functionality in netpod disconnect cases that lead to an
infinite loop

Also fixes an errant message from #78959
## Why It's Good For The Game
Fixes #79190

## Changelog
:cl:
fix: Entering a virtual domain should no longer give you a message that
it doesn't forbid items
/:cl:

---------

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Fixes infinite loop in bitrunning

---------

Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
@Iajret Iajret merged commit 9c21af4 into master Oct 23, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-24534 branch October 24, 2023 00:00
AnywayFarus added a commit that referenced this pull request Oct 24, 2023
Iajret pushed a commit that referenced this pull request Jan 3, 2024
* saves 90 seconds of cpu time in every 60 hour round. (#80682)

/datum/proc/process() does nothing and having it in the top 100 called
because of this one line is silly.

* saves 90 seconds of cpu time in every 60 hour round.

---------

Co-authored-by: Kyle Spier-Swenson <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants