Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes crafting menu not detecting ingredients properly #223

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24513
Original PR: tgstation/tgstation#79141

About The Pull Request

  1. Fixes #79089
    This fix applies for the above issue and all crafting recipes that require some sort of reagent container containing reagents. It now adds the container & the reagents inside of it to the list of available ingredients & not just the reagents which was previously the case.

  2. Fixes #79159
    Other crafting ingredients in general were not being detected if it was not a stack type. That's fixed now too

Changelog

🆑 SyncIt21
fix: items that require reagent containers & the reagents inside it for crafting(e.g. molotov) now crafts properly.
fix: most crafting recipes should work now
/:cl:

…IGNORE] (#24513)

* Fixes crafting menu not detecting ingredients properly (#79141)

## About The Pull Request
1. Fixes #79089
This fix applies for the above issue and all crafting recipes that
require some sort of reagent container containing reagents. It now adds
the container & the reagents inside of it to the list of available
ingredients & not just the reagents which was previously the case.

2. Fixes #79159
Other crafting ingredients in general were not being detected if it was
not a stack type. That's fixed now too

## Changelog
:cl:
fix: items that require reagent containers & the reagents inside it for
crafting(e.g. molotov) now crafts properly.
fix: most crafting recipes should work now
/:cl:

* Fixes crafting menu not detecting ingredients properly

---------

Co-authored-by: SyncIt21 <[email protected]>
@AnywayFarus AnywayFarus merged commit 58df37c into master Oct 23, 2023
23 checks passed
AnywayFarus added a commit that referenced this pull request Oct 23, 2023
@AnywayFarus AnywayFarus deleted the upstream-mirror-24513 branch October 23, 2023 08:06
Iajret pushed a commit that referenced this pull request Jan 3, 2024
* adds screentips to the janicart (pimpin' ride) (#80665)

## About The Pull Request
Adds screentips the janicart (pimpin' ride) for dismounting, adding and
removing trash bags/upgrades/keys and inserting into the connected trash
bag.

The dismounting and key insertion/removal screentips could maybe be used
in the base vehicle. But right now I can't figure out how to move those
there without needing to do the same checks on the janicart (pimpin'
ride) again.
## Why It's Good For The Game
The janicart (pimpin' ride) has a lot of things you can do with it that
are not immediately obvious. It took me a while to figure out that you
can grab the trash bag from it without having to get off of it first.
## Changelog
:cl:
qol: added screentips to the janicart (pimpin' ride)
/:cl:

* adds screentips to the janicart (pimpin' ride)

---------

Co-authored-by: kawoppi <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants