[MIRROR] Splits up a big file in the nukie antagonist folder #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits up a big file in the nukie antagonist folder * Deletes a file that should have been deleted --------- Co-authored-by: Rhials <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 2, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Adds a funny scene when getting Sisyphus achievement (#82897) ## About The Pull Request https://github.com/tgstation/tgstation/assets/137328283/979231c3-70cd-49dd-8d4d-2a8554adfbb3 ## Why It's Good For The Game This PR makes getting the “Ordeal of Sisyphus” extremely pointless by teleporting carried boulder and spessman back to the Lavaland. In my opinion, this feature is funny and suits the spirit of this achievement. ## Changelog :cl: add: Added a short scene when getting an Ordeal of Sisyphus achievement. /:cl: * Adds a funny scene when getting Sisyphus achievement --------- Co-authored-by: Interception&? <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1237
Original PR: tgstation/tgstation#81632
About The Pull Request
This hacks up the nukeop.dm file in the antagonists/nukeop folder.
This was originally for the antag datum, and became a kitchen sink that a lot of disparate stuff got dumped into. Now, the code has been split up into individual folders (based on antag/team datum type) and put into order.
In doing all this, I noticed that the reinforcement datum is unused, and the fix PR for that will probably merge conflict with this (arghghhhh).
Why It's Good For The Game
Sweep sweep tidy code makes my brain feel better.
I was going to add something that needed a new nukie antag datum type and couldn't bring myself to cram it into the already bloated nukeop.dm file, so we must do this first.
Changelog
🆑 Rhials
code: Splits up the nuclear operative antagonist datum folder.
/:cl: