[MIRROR] Prettifies Adminwho into an Examine Block #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prettifies Adminwho into an Examine Block (#79137) ## About The Pull Request Same vein of #71170 (2d3e7f2383e40d12bf0bf8dde755b9931aefae3f) / #69845 (61d49cb11aee8acdacda6d7707d3edf1cd0a5a0b) in an attempt to lessen the number of cruddy "system messages" that just print straight text to chat. This could be improved CSS wise but I think a standard examine block helps a lot while maintaing clarity, see below:  I also heavily refactored adminwho code to not have so much copypasta while using more `jointext()` and keeping everything a bit more readable than what it previously was. User-facing stuff should all be the same (with the addition of an examine block) except in two spots * Custom header message when no admins are online. I think this is a far clearer message than having `Current Admins:` and then the message about adminhelps being relayed to Discord * There's no tabs per each entry. This was replaced by a bullet point. I think it's better to read. ## Why It's Good For The Game As time goes on, I'm more and more peeved by these pretty critical messages constantly blending in with output from the rest of the game. This is why balloon_alerts and whatever became so popular to my eyes, there's just constant junk. I figure that we may as well just keep the systematic stuff that _must_ live in the chat box looking as neat as possible. ## Changelog :cl: qol: Adminwho messages are now in an examine block for heightened clarity. /:cl: * Prettifies Adminwho into an Examine Block --------- Co-authored-by: san7890 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Oct 23, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Fixes extinguisher cabinet not updating its icon (#80668) ## About The Pull Request Just makes the extinguisher cabinet actually look opened after removing the extinguisher like it's supposed to. ## Why It's Good For The Game <details><summary>Looks like it's supposed to again</summary>  </details> ## Changelog :cl: fix: fixed fire extinguisher cabinets not appearing opened after removing the fire extinguisher from them /:cl: * Fixes extinguisher cabinet not updating its icon --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24514
Original PR: tgstation/tgstation#79137
About The Pull Request
Same vein of #71170 (2d3e7f2383e40d12bf0bf8dde755b9931aefae3f) / #69845 (61d49cb11aee8acdacda6d7707d3edf1cd0a5a0b) in an attempt to lessen the number of cruddy "system messages" that just print straight text to chat.
This could be improved CSS wise but I think a standard examine block helps a lot while maintaing clarity, see below:
I also heavily refactored adminwho code to not have so much copypasta while using more
jointext()and keeping everything a bit more readable than what it previously was. User-facing stuff should all be the same (with the addition of an examine block) except in two spotsCurrent Admins:and then the message about adminhelps being relayed to DiscordWhy It's Good For The Game
As time goes on, I'm more and more peeved by these pretty critical messages constantly blending in with output from the rest of the game. This is why balloon_alerts and whatever became so popular to my eyes, there's just constant junk. I figure that we may as well just keep the systematic stuff that must live in the chat box looking as neat as possible.
Changelog
🆑 san7890
qol: Adminwho messages are now in an examine block for heightened clarity.
/:cl: