Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] adds extra explainer text on updated BB convert objective #2209

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1218
Original PR: tgstation/tgstation#81734

About The Pull Request

something something the universe of all possible cases

fixes #81731

Why It's Good For The Game

cyborg bait not good. also follow your laws first robot!

Changelog

…ective (#1218)

* [NO GBP] adds extra explainer text on updated BB convert objective (#81734)

## About The Pull Request

something something the universe of all possible cases 
 
fixes #81731

## Why It's Good For The Game

cyborg bait not good. also follow your laws first robot!

## Changelog

* [NO GBP] adds extra explainer text on updated BB convert objective

---------

Co-authored-by: Higgin <[email protected]>
@Iajret Iajret merged commit f2a20fa into master Mar 1, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1218 branch March 1, 2024 14:06
Iajret pushed a commit that referenced this pull request Apr 28, 2024
)

* Turf weakref persists in changeturf / Fix plasma cutters  (#82906)

## About The Pull Request

Turf references don't change so logically, turf weakrefs wouldn't change
if the turf changes.

By not doing this this can cause bugs: See #82886 . (This Fixes #82886) 

(Projectiles hold a list of weakrefs to atoms hit to determine what they
have already hit.

Because turf weakrefs reset, we could "hit" the same turf twice if it
destroyed the turf.

Old behavior - this was fine but now that they're weakrefs, we get two
weakref datums in the list that point to the same ref.)

Less hacky alternative to #82901 . (Closes #82901) 

## Changelog

:cl: Melbert
fix: Plasma cutters work again
/:cl:

* Turf weakref persists in changeturf / Fix plasma cutters

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants