[MIRROR] wew lad: variable defined but not used
#2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wew `lad: variable defined but not used` Co-authored-by: Ghom <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 27, 2024
…ed ghost roles (#2201) * Fix malf AI being unable to trigger because AIs are considered ghost roles (#82893) ## About The Pull Request Fix #82891 PR #82030 added this job flag check to dynamic candidate trimming https://github.com/tgstation/tgstation/blob/cd29b123eff035fff7da10d21f8d55e1c898670f/code/controllers/subsystem/dynamic/dynamic_rulesets_midround.dm#L77-L79 Problem: AIs do not have `JOB_CREW_MEMBER`! This meant that all AI mobs were trimmed out of the candidate list for midround malf, so no it always failed This PR fixes this by flipping `restrict_ghost_roles` to `FALSE` for midround malf and then tightening up some of the checks to ensure off station AIs don't roll malf. ## Changelog :cl: Melbert fix: Midround malf can roll again /:cl: * Fix malf AI being unable to trigger because AIs are considered ghost roles --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1213
Original PR: tgstation/tgstation#81703
About The Pull Request
Thanks Floofies for the PR title.
This removes a warning that flew under the radar, passed the CI without me taking a deeper look basically.
Why It's Good For The Game
Removing an unused variable.
Changelog
N/A