[MIRROR] Peddling Purple Prose: Porting the 'Do' action from F13 #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit of Do roleplay action * Link in correct keybind signal * Update unit tests * I want to throw eslint down a well * Move to mob/living and change to use hearers instead of view() * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Fix compile issues * Yabba dabba Do * Allow AI to Do from their eyeobj position (and also hear from it as well) --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#725
About The Pull Request
Inspired quite directly from https://github.com/f13babylon/f13babylon/pull/200 after several people requested it in #main-talk earlier today, I've taken the liberty of porting a best shot implementation of a 'do' action in our codebase - fully, in TGUI as a new chat channel similar to LOOC and whispers plus a longform version.
The command is initially bound to K in its tgui_say shortform, and Ctrl+K in its tgui_input_text longform. Totally changeable to whatever you like!
A picture's worth a thousand words, so here's some snippets of Do in its natural habitat:
As noted, Do sends as much via runechat as it can for shortform enjoyers. At some point I'll figure out how to change the asterisk in runechat emotes into something else, but that something else is not today.
How This Contributes To The Nova Sector Roleplay Experience
Though simple in nature, this adds an entirely new way for people to express themselves in prose without having to innately include their character in the end result. Allows for a lot of believable soft-DMing of the environment in many cases - this kind of functionality is a staple in many MUD codebases for this reason, and it'll do wonders for people who like it here.
Proof of Testing
See description!
Changelog
🆑 yooriss
add: A new form of emoting is available called 'Do', accessible via the K and Ctrl-K keybinds by default (as well as the 'Do' verb). Do doesn't put your character name first and instead includes it in brackets at the end, so you can use it to write better prose and even narrate things in the environment around you with less clunkiness! Try it out today.
/:cl: