Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Lowers thermic constant of Cryostylane reaction #2182

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1192
Original PR: tgstation/tgstation#81709

About The Pull Request

  • Fixes #81687

Thermic constant of Cryostylane reaction now reduced from -7.5 to -1.5.

Meaning for every 1u of Cryostylane created the overall temperature of the holder reduces by 1.5k so for e.g. if you create 30u of cryostylane without any heating the temps reduces by 30 * 1.5 = 45k(the drop of temperature increases as the reaction temps grows closer to optimal temperature in our case -200k)

When testing upon adding 30u of water, nitrogen & stable plasma and cooling the mixture to 270k via tier1 chem heater you acheive 30u of Cryostylane at 82% purity and the final temps are 180k

P.S. adjusted range of chem debuger to include negative values. Helped me in debugging this

Changelog

🆑 SyncIt21
fix: Cryostylane reaction now has a moderate & not extreme cooling effect. Helps you achieve more pure amounts of Cryostylane
/:cl:

* Lowers thermic constant of Cryostylane reaction (#81709)

## About The Pull Request
- Fixes #81687

Thermic constant of Cryostylane reaction now reduced from -7.5 to -1.5.

Meaning for every 1u of Cryostylane created the overall temperature of
the holder reduces by 1.5k so for e.g. if you create 30u of cryostylane
without any heating the temps reduces by 30 * 1.5 = 45k(the drop of
temperature increases as the reaction temps grows closer to optimal
temperature in our case -200k)

When testing upon adding 30u of water, nitrogen & stable plasma and
cooling the mixture to 270k via tier1 chem heater you acheive 30u of
Cryostylane at 82% purity and the final temps are 180k

P.S. adjusted range of chem debuger to include negative values. Helped
me in debugging this

## Changelog
:cl:
fix: Cryostylane reaction now has a moderate & not extreme cooling
effect. Helps you achieve more pure amounts of Cryostylane
/:cl:

* Lowers thermic constant of Cryostylane reaction

---------

Co-authored-by: SyncIt21 <[email protected]>
@Iajret Iajret merged commit cc9dff8 into master Feb 29, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1192 branch February 29, 2024 18:40
AnywayFarus added a commit that referenced this pull request Feb 29, 2024
Iajret pushed a commit that referenced this pull request Apr 25, 2024
#2182)

* Fix: Makes the rebar crossbow's bowstring loosen after firing (#82830)

## About The Pull Request

As it stands, after the rebar crossbow fires, it must be used inhand
twice, once to loosen the bowstring, and a second time with a do_after
to pull it back. Not only does this make no sense as the bowstring is
what launches the projectile, but I actually had no idea it was even
happening, until I got it pointed out on discord.

## Why It's Good For The Game

The main reason is that the crossbow shooting a rod without moving the
bowstring just looks weird, but also given the first inhand use doesn't
have a delay, it also doesn't really serve any purpose.

## Changelog
:cl:
fix: The rebar crossbows now properly loosen their bowstring upon
firing.
/:cl:

* Fix: Makes the rebar crossbow's bowstring loosen after firing

---------

Co-authored-by: KingkumaArt <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 26, 2024
#2182) (#3062)

* Fix: Makes the rebar crossbow's bowstring loosen after firing (#82830)

## About The Pull Request

As it stands, after the rebar crossbow fires, it must be used inhand
twice, once to loosen the bowstring, and a second time with a do_after
to pull it back. Not only does this make no sense as the bowstring is
what launches the projectile, but I actually had no idea it was even
happening, until I got it pointed out on discord.

## Why It's Good For The Game

The main reason is that the crossbow shooting a rod without moving the
bowstring just looks weird, but also given the first inhand use doesn't
have a delay, it also doesn't really serve any purpose.

## Changelog
:cl:
fix: The rebar crossbows now properly loosen their bowstring upon
firing.
/:cl:

* Fix: Makes the rebar crossbow's bowstring loosen after firing

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: KingkumaArt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants