[MIRROR] Reverses the logic for body collision to determine knockdown #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…knockdown (#1190) * [NO GBP] Reverses the logic for body collision to determine knockdown (#81712) ## About The Pull Request The body that is thrown at someone having knockdown proofing is not what determines whether the victim of the collision is knocked over, but the victim themselves having this trait. ## Why It's Good For The Game I have ADHD. ## Changelog :cl: fix: Being in a Swat Suit appropriately protects you from collisions with a body, rather than the body thrown at you having these protections protecting YOU, the victim of the collision. /:cl: * [NO GBP] Reverses the logic for body collision to determine knockdown --------- Co-authored-by: necromanceranne <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 29, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 25, 2024
* [no gbp] actually fixes bot access (#82809) ## About The Pull Request real fix to bots having AA. also i forgot to address simple bots in my previous attempt so this fixes them too ## Why It's Good For The Game fixes bots having AA ## Changelog :cl: fix: all bots have their normal accesses restored /:cl: * [no gbp] actually fixes bot access --------- Co-authored-by: Ben10Omintrix <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 26, 2024
* [no gbp] actually fixes bot access (#82809) ## About The Pull Request real fix to bots having AA. also i forgot to address simple bots in my previous attempt so this fixes them too ## Why It's Good For The Game fixes bots having AA ## Changelog :cl: fix: all bots have their normal accesses restored /:cl: * [no gbp] actually fixes bot access --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Ben10Omintrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1190
Original PR: tgstation/tgstation#81712
About The Pull Request
The body that is thrown at someone having knockdown proofing is not what determines whether the victim of the collision is knocked over, but the victim themselves having this trait.
Why It's Good For The Game
I have ADHD.
Changelog
🆑 necromanceranne
fix: Being in a Swat Suit appropriately protects you from collisions with a body, rather than the body thrown at you having these protections protecting YOU, the victim of the collision.
/:cl: