[MIRROR] Removes the old toolbox arena code #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes the old toolbox arena code (#81707) ## About The Pull Request This machine was added 5 years ago to be used for events like the toolbox tournament, but it has since been deprecated and unused (toolbox tournament has made their own version of the console that works much better and uses TGUI), making this machine not worth touching. After some discussions in discord, we said the better option would be to remove this machine and leave the toolbox tournament branch keep using their machine, rather than to port the toolbox version to TG where it will continue to not be used in-game. fun fact: This used to have a feature where it gave antag hud icons to the members of each team, it was removed when antag huds got refactored 3 years ago, hence why I'm removing an antag hud icon. ## Why It's Good For The Game Already explained, this machine has no purpose as it is now, and a new tgui UI won't save it. ## Changelog Nothing player-facing. * Removes the old toolbox arena code --------- Co-authored-by: John Willard <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 25, 2024
* ChemMaster 3000 printing speed based on servo tier (#82836) ## About The Pull Request Reverts the maximum number of containers (pills/patches/etc.) the ChemMaster 3000 can print back to 50. (Recently changed to 12.5 per tier in tgstation/tgstation#82002) Instead, the servo tier determines the speed the batch is printed at.   ## Why It's Good For The Game Refilling the buffer and pressing print for every 13 pills is pointless busywork when there is already a delay now implemented per pill printed. ## Changelog :cl: LT3 balance: ChemMaster can again print a maximum of 50 pills/patches per run balance: Higher tier servos increase ChemMaster printing speed /:cl: * ChemMaster 3000 printing speed based on servo tier --------- Co-authored-by: lessthanthree <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 26, 2024
…3056) * ChemMaster 3000 printing speed based on servo tier (#82836) ## About The Pull Request Reverts the maximum number of containers (pills/patches/etc.) the ChemMaster 3000 can print back to 50. (Recently changed to 12.5 per tier in tgstation/tgstation#82002) Instead, the servo tier determines the speed the batch is printed at.   ## Why It's Good For The Game Refilling the buffer and pressing print for every 13 pills is pointless busywork when there is already a delay now implemented per pill printed. ## Changelog :cl: LT3 balance: ChemMaster can again print a maximum of 50 pills/patches per run balance: Higher tier servos increase ChemMaster printing speed /:cl: * ChemMaster 3000 printing speed based on servo tier --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: lessthanthree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1191
Original PR: tgstation/tgstation#81707
About The Pull Request
This machine was added 5 years ago to be used for events like the toolbox tournament, but it has since been deprecated and unused (toolbox tournament has made their own version of the console that works much better and uses TGUI), making this machine not worth touching.
After some discussions in discord, we said the better option would be to remove this machine and leave the toolbox tournament branch keep using their machine, rather than to port the toolbox version to TG where it will continue to not be used in-game.
fun fact: This used to have a feature where it gave antag hud icons to the members of each team, it was removed when antag huds got refactored 3 years ago, hence why I'm removing an antag hud icon.
Why It's Good For The Game
Already explained, this machine has no purpose as it is now, and a new tgui UI won't save it.
Changelog
Nothing player-facing.