[MIRROR] Ruin cleanup pass 1 - Shuttle8532, Cafe, Space Hotel, Interlink #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cafe Shuttle8532 icewalker * gemmed necklace * whoopsie daises * cats * smol * Update CentCom_nova_z2.dmm * Update icemoon_underground_icewalker_lower.dmm * Update icemoon_underground_icewalker_lower.dmm * Disposals for Cafe/Interlink * Missing disposals in Hotel * Hotel access * Config updates * Further Cleanup + suggestions * don't think we need double messages * must as well do it for the Ashen too * Update necklace.dm * 1 * to_chat * Apply suggestions from code review * ashiestoo * Refactor this, fix bugs * Update necklace.dm * Update necklace.dm * Fixes second message not displaying * Update necklace.dm * Update necklace.dm * Update necklace.dm * Update modular_nova/modules/primitive_catgirls/code/clothing.dm * This does not belong there --------- Co-authored-by: Bloop <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 25, 2024
* fixes ai controllers hard deletes (#82861) ## About The Pull Request  i noticed almost all ai controllers were being hard deleted, its because the controller itself was being addedto the behavior_cooldowns list rather than the behavior itself ## Why It's Good For The Game fixes hard deletes ## Changelog :cl: /:cl: * fixes ai controllers hard deletes --------- Co-authored-by: Ben10Omintrix <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 26, 2024
* fixes ai controllers hard deletes (#82861) ## About The Pull Request  i noticed almost all ai controllers were being hard deleted, its because the controller itself was being addedto the behavior_cooldowns list rather than the behavior itself ## Why It's Good For The Game fixes hard deletes ## Changelog :cl: /:cl: * fixes ai controllers hard deletes --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Ben10Omintrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1144
About The Pull Request
This one's a QOL pass that i've been meaning to get to for a couple weeks:
Shuttle8532 - I hate having the fact you get a free syndicate modsuit without any effort, so i made it require effort. You now actually have to solve the puzzle of the ship instead of cheesing through the wall.
Icewalkers - nothing changed except i added in a gemmed necklace, it's an ashen necklace basically but for the cats. I was going to start respriting it but realize that the sprite itself can easily fit the idea of it. Currently this exists in the Cafe only
Cafe - added both the Ashen and Gemmed necklaces to their respective areas and DISPOSALS
Interlink - Added Disposals
Space Hotel - Fixed the missing disposal corner that Lilly Sammich has rightfully bapped me for missing
Config - ruins are now added to the config list proper
How This Contributes To The Nova Sector Roleplay Experience
Enables roleplay in the Cafe between tribals/non tribals
Enables a high-value item for the icewalkers - the gemmed necklace
Shuttle 8532 isnt a free syndie suit anymore
Proof of Testing
Screenshots/Videos
Ruins are now ruins!Call the press, the synths are speaking tongues
Ruins are now ruins!
Changelog
🆑 Zergspower
add: Added a translator necklace for hearthkin, granting 4 to the cafe giving those who wear it the ability to speak siiktajr
qol: Cafe now has the gemmed and ashen necklaces in their respective areas
qol: Cafe and Interlink now have Disposals
Fix: Missing Space hotel Disposals line
balance: Shuttle 8532 actually requires thinking and skill to not die
admin: Ruin names now have their identifier placed in the front, making it easier to pick them out of the massive list
/:cl: