Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix rat heart #2175

Merged
merged 2 commits into from
Mar 1, 2024
Merged

[MIRROR] Fix rat heart #2175

merged 2 commits into from
Mar 1, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1184
Original PR: tgstation/tgstation#81698

About The Pull Request

Fixes #81696

on_mob_insert doesn't return a truthy value from parent call, it returns null / nothing

Also patches a potential exploit involving that can mutate check

Changelog

🆑 Melbert
fix: Rat hearts apply their damage modifier malus correctly
/:cl:

* Fix rat heart (#81698)

## About The Pull Request

Fixes #81696

`on_mob_insert` doesn't return a truthy value from parent call, it
returns null / nothing

Also patches a potential exploit involving that can mutate check 

## Changelog

:cl: Melbert
fix: Rat hearts apply their damage modifier malus correctly
/:cl:

* Fix rat heart

---------

Co-authored-by: MrMelbert <[email protected]>
@Iajret Iajret merged commit 843b138 into master Mar 1, 2024
23 checks passed
AnywayFarus added a commit that referenced this pull request Mar 1, 2024
@Iajret Iajret deleted the upstream-mirror-1184 branch March 1, 2024 14:06
Iajret pushed a commit that referenced this pull request Apr 25, 2024
… of reftracking (#2175)

* Adds handy define that enables the most common configuration of reftracking (#82860)

## About The Pull Request

This shit has confused people too many times, let's give them an easy
pathway to use reftracking

Also split the separate logging bit into its own thing

* Adds handy define that enables the most common configuration of reftracking

---------

Co-authored-by: LemonInTheDark <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 26, 2024
… of reftracking (#2175) (#3053)

* Adds handy define that enables the most common configuration of reftracking (#82860)

## About The Pull Request

This shit has confused people too many times, let's give them an easy
pathway to use reftracking

Also split the separate logging bit into its own thing

* Adds handy define that enables the most common configuration of reftracking

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: LemonInTheDark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants