[MIRROR] Fix Bluespace RPEDs not applying circuits at a distance when you have multiple options. #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… you have multiple options. (#1175) * Fix Bluespace RPEDs not applying circuits at a distance when you have multiple options. (#81670) ## About The Pull Request As per #81668, Bluespace RPEDs weren't applying circuits at a distance if you had multiple options. Looking into it, this seemed to be because the sanity checks after the selection menu had been closed accounted for adjacency but not that the replacer could work at a distance. Adding a check for this fixed it. I then decided splitting this off into its own if statement would be best for our long-term sanity, given the first if was getting quite long and the added parenthesis really would not help. ## Why It's Good For The Game Fixes #81668. ## Changelog :cl: fix: Fixed Bluespace RPEDs failing to apply circuits from a distance if you had to select between multiple. /:cl: * Fix Bluespace RPEDs not applying circuits at a distance when you have multiple options. --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 28, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 24, 2024
…#2169) * Fixes some rando failures off the ignore list of projectiles (#82855) * Fixes some rando failures off the ignore list of projectiles --------- Co-authored-by: LemonInTheDark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1175
Original PR: tgstation/tgstation#81670
About The Pull Request
As per #81668, Bluespace RPEDs weren't applying circuits at a distance if you had multiple options.
Looking into it, this seemed to be because the sanity checks after the selection menu had been closed accounted for adjacency but not that the replacer could work at a distance.
Adding a check for this fixed it.
I then decided splitting this off into its own if statement would be best for our long-term sanity, given the first if was getting quite long and the added parenthesis really would not help.
Why It's Good For The Game
Fixes #81668.
Changelog
🆑 00-Steven
fix: Fixed Bluespace RPEDs failing to apply circuits from a distance if you had to select between multiple.
/:cl: