[MIRROR] Make lobby manifest use trim instead of rank to determine command status #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand status (#1173) * Make lobby manifest use trim instead of rank to determine command status * Update manifest.dm * Update CrewManifest.jsx * No longer an edit --------- Co-authored-by: _0Steven <[email protected]> Co-authored-by: Bloop <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Accessing Datasystem Manager from MC controller panel (#82848) * Accessing Datasystem Manager from MC controller panel --------- Co-authored-by: EvilDragonfiend <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1173
Original PR: tgstation/tgstation#81636
About The Pull Request
The lobby manifest shows a symbol next to command roles, one for heads and for captains respectively, but this stops working when the job title is changed even though they do still have a head/captain ID.
This is because it compares the registered job title to a set list, rather than the registered ID trim which is normally unchanging.
Making it use the trim instead solves this issue.
Why It's Good For The Game
Sometimes people have custom head titles, whether by admin intervention or just having fun, and then it's just confusing.
This fixes that.
It's also just kinda annoying to see the one custom head not having the head symbol.
Changelog
Already had this here