Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Xenomorph stomachs and vore will no longer destroy items directly, refactored it to use acid_act() #2166

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1169
Original PR: tgstation/tgstation#81534

About The Pull Request

senomorph stomachs and vore will no longer destroy items and mobs directly, refactored it to use acid_act()
fixes xenomorph vore accidentally destroying mobs it wasn't supposed to destroy, im thinking this was modified list in place shenanigans

Why It's Good For The Game

this shit is jank as hell and better done this way and results in less weird edge cases, and also makes xenomorphs feel less bullshit

Changelog

🆑 Iamgoofball
balance: xenomorph stomachs will no longer destroy items directly, refactored it to use acid_act()
fix: fixes xenomorph vore accidentally destroying mobs it wasn't supposed to destroy, im thinking this was modified list in place shenanigans
/:cl:

…ectly, refactored it to use acid_act() (#1169)

* Xenomorph stomachs and vore will no longer destroy items directly, refactored it to use acid_act() (#81534)

## About The Pull Request

senomorph stomachs and vore will no longer destroy items and mobs
directly, refactored it to use acid_act()
fixes xenomorph vore accidentally destroying mobs it wasn't supposed to
destroy, im thinking this was modified list in place shenanigans

## Why It's Good For The Game

this shit is jank as hell and better done this way and results in less
weird edge cases, and also makes xenomorphs feel less bullshit

## Changelog

:cl:
balance: xenomorph stomachs will no longer destroy items directly,
refactored it to use acid_act()
fix: fixes xenomorph vore accidentally destroying mobs it wasn't
supposed to destroy, im thinking this was modified list in place
shenanigans
/:cl:

* Xenomorph stomachs and vore will no longer destroy items directly, refactored it to use acid_act()

---------

Co-authored-by: Iamgoofball <[email protected]>
@Iajret Iajret merged commit 60aaaa8 into master Feb 29, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1169 branch February 29, 2024 18:28
AnywayFarus added a commit that referenced this pull request Feb 29, 2024
Iajret pushed a commit that referenced this pull request Apr 26, 2024
* lewd restraining cd fix

* fix 1

Co-authored-by: Bloop <[email protected]>

* fix 2

---------

Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants