[MIRROR] TRAIT_DEAF now works on non-carbon mobs #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TRAIT_DEAF now works on non-carbon mobs (#81624) ## About The Pull Request This PR makes it so that the `can_hear` proc will return `FALSE` if the proc is called on a non-carbon that has the deaf trait. ## Why It's Good For The Game This makes it so that non-carbon mobs can have the TRAIT_DEAF added to them and it will now work. There isn't anything that would currently utilize this on here. But, I do have a project downstream where TRAIT_DEAF is added to a non-carbon mob. ## Changelog :cl: code: TRAIT_DEAF now works on non-carbon mobs /:cl: --------- Co-authored-by: MrMelbert <[email protected]> * TRAIT_DEAF now works on non-carbon mobs --------- Co-authored-by: Pinta <[email protected]> Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 29, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 24, 2024
…2163) * Adds sorting options and a search bar to the crew monitor (#82732) ## About The Pull Request This PR adds buttons in the crew monitor UI to sort by name, position, or vitals, as well as a search bar for searching for specific people. For vitals, people are sorted first by life status (living, crit, dead, etc), then by damage. Also TS-ifies the UI. https://github.com/tgstation/tgstation/assets/42454181/a7c0c262-8ea7-4e9f-8de6-6b9cf7481b23 ## Why It's Good For The Game Currently, finding a specific person, or a person in a specific place, is a pain in the butt with the crew monitor. You have to go through an unsorted list of people grouped only by department. Don't know the person's job? Tough luck, you're going down the list one by one. It is not at all a friendly user experience. With this PR, it becomes a breeze, and makes the crew monitor much easier to use. ## Changelog :cl: add: The crew monitor now has sorting options and a search bar. /:cl: * Adds sorting options and a search bar to the crew monitor --------- Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1165
Original PR: tgstation/tgstation#81624
About The Pull Request
This PR makes it so that the
can_hearproc will returnFALSEif the proc is called on a non-carbon that has the deaf trait.Why It's Good For The Game
This makes it so that non-carbon mobs can have the TRAIT_DEAF added to them and it will now work. There isn't anything that would currently utilize this on here. But, I do have a project downstream where TRAIT_DEAF is added to a non-carbon mob.
Changelog
🆑 softcerv
code: TRAIT_DEAF now works on non-carbon mobs
/:cl: