[MIRROR] Fix custom job titles displaying with question mark icons in medical/security records. #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… medical/security records. (#1148) * Fix custom job titles displaying with question mark icons in medical/security records. * Conflict fix * Update types.ts * Update medical.dm --------- Co-authored-by: _0Steven <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 29, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 24, 2024
… you cough less (#2158) * Tuberculosis makes you cough more, Nicotine Withdrawal makes you cough less (#82827) ## About The Pull Request - Tuberculosis makes you cough more, and is no longer restricted to stage two - Nicotine Addiction Withdrawal makes you cough less often - Medicine Addiction Withdrawal makes you cough less often but now carries across all stages ## Why It's Good For The Game Nicotine Addiction currently makes you cough 10x more often than Tuberculosis, the lung disease. Kinda nonsensical right? This makes smoking a single cigar (which instantly makes you addicted because lol) pretty insufferable to be around, and while this makes sense OOC it's a roleplaying game and being actively avoided in a roleplaying game is not fun So tweaking the values should make it a bit more sensible Initial values looked like `TB: 1% chance per second` vs `Nicotine: 10% chance per second` 🥴 ## Changelog :cl: Melbert qol: Tuberculosis makes you cough more qol: Nicotine Addiciton makes you cough less qol: Medicine Addiction maybe makes you cough more, maybe makes you cough less /:cl: * Tuberculosis makes you cough more, Nicotine Withdrawal makes you cough less --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1148
Original PR: tgstation/tgstation#81637
About The Pull Request
Medical/Security records display a nice little icon next to each name in their list of registered crew, based on what their job on the station is.
However, this is based off of
rankand thus the actual job title, meaning anyone with a hop-customized job title would have a question mark icon instead.By changing it to use
trim, which is set from the ID's trim rather than title when updating the manifest, custom titles work perfectly fine and the records instead display an icon based on the ID's trim.Why It's Good For The Game
Better than having a question mark icon for every single custom job, especially when it's just a hop adding a modifier to an existing job to reflect extra access.
Changelog
🆑 00-Steven
fix: Medical/security records now show an icon based on the registered trim, rather than showing a question mark for records with customized titles.
/:cl: