Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds Security Shorts (& One Pair Of Pants) #2156

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1138

About The Pull Request

How's it going.
Check this out, right?

image

Here's some shorts.
Short, and shorter. These do have white variants.

But I know. You're unconvinced.
Watch this swag.

image

How's about with the jacket?
image
Perfect.

Unzip it?
Sure.
image
Midriff?
image
You bet your sweet bippy you can.

But, shorter?
image

Coat off?
image

Slutty hip windows?
image

Jacket?
image

White?
image

Frontier boots?
image

As you can see, this will be the new meta.

How This Contributes To The Nova Sector Roleplay Experience

I think there's direct benefits tied to letting sec dress in 'fun' ways. The less they look like all-black superLARPers, the more personable they perform. What's more personable than a bit of leg? We've got spring and summer upcoming as well. We can see the apex of 'Guard' over 'Soldier' design in the department guard stuff as well.

Or if you're unconvinced by my argument there.
image

Proof of Testing

Screenshots/Videos In the desc.

Changelog

🆑 Nerev4r
add: Adds some Security shorts to the loadout and vendors.
/:cl:

* the most powerful pr ever made

* Update modular_nova/master_files/code/modules/clothing/under/jobs/security.dm

Co-authored-by: OrionTheFox <[email protected]>

---------

Co-authored-by: OrionTheFox <[email protected]>
@Iajret Iajret merged commit b045b66 into master Feb 28, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1138 branch February 28, 2024 11:36
AnywayFarus added a commit that referenced this pull request Feb 28, 2024
Iajret pushed a commit that referenced this pull request Apr 24, 2024
* Fix playing card memory (#82834)

## About The Pull Request

`/datum/memory/playing_cards` accepts a list of other players, which it
uses to format into an english list.

But where it is applied, it takes a list of players, formats it into an
english list, and passes it in. Oops.

Also fixed some verbage for how the memories look in-story-form. 

## Changelog

:cl: Melbert
fix: Playing Cards memory now reads better
/:cl:

* Fix playing card memory

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants