[MIRROR] [PORT] Synths Update: The ID Reckoning #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial d * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * there are consequences to your crimes against dracula * a real human being * ayo * wowza * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Update modular_nova/modules/synths/code/bodyparts/internal_computer/internal_computer.dm Co-authored-by: Bloop <[email protected]> * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * wew * yay * Moves signal proc to the pda itself * Starting with id already equipped will auto-link it to the synth brain computer * Make sure removing from pda/wallets unlink properly * Fixes pdas and wallets edge cases (hopefully) * Update internal_computer.dm * This got so needlessly complicated --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1032
About The Pull Request
Special thanks to @Majkl-J!
Dejanks the id slot in synth computers by making the computer read directly from your id slot. Cleans up synth code from all the now useless code.
Introduces COMSIG_HUMAN_UNEQUIPPED_ITEM due to some signal related jank which would've made this unable to work otherwise.
I threw in, on top of Waterpig's changes, some messages to clarify what ID is currently loaded in. There was going to be a disconnect message, but it'd play not only when you took the thing out of the slot but when it was out of your inventory at all. It playing twice nearly drove me to insanity, so. Not today.
How This Contributes To The Nova Sector Roleplay Experience
Synths can no longer do silly ID hiding, also the ID slot now makes their computers much easier to use.
Proof of Testing
Screenshots/Videos
Changelog
🆑 Nerev4r
add: New persocom wireless standards have allowed for machines to wirelessly link to ID cards, rather than using dedicated slots.
/:cl: