[MIRROR] General maintenance for frames #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* General maintenance for frames (#81473) ## About The Pull Request Builds upon the changes in tgstation/tgstation#81477 **1. Qol** - Adds detailed examines & screentips for building & deconstructing both machine & computer frames - Adding a circuitboard from a rped to a computer frame will automatically screw it in place like before **2. Code Improvements** - Merged procs like `update_path_names()` , `get_requested_amt()` etc into their required places to reduce proc calls - Autodocs procs like `add_cable()`, `add_glass()` etc. makes them private - Moved code for machine frame into its own file * General maintenance for frames --------- Co-authored-by: SyncIt21 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 29, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Plumbing & chem reaction chamber patches (#82781) ## About The Pull Request 1. Both Plumbing & Chem reaction chamber will use the beakers `heat_capacity()` proc instead of the formulae `SPECIFIC_HEAT_DEFAULT * reagents.total_volume`. This yields the exact same results as before but will mean in the future if individual reagents heat capacities are changed then the heating effects will be accurately reflected here. It also uses that amount of power for heating 2. Plumbing rection chamber will not use energy when its either 'emptying' or when no reagents are present in its internal buffer 3. You can hit the chem reaction chamber with items like beakers, screwdrivers, crowbars and what not ## Changelog :cl: fix: plumbing & chem reaction chamber heating effects accurately reflect the beakers heat capacity & power usage fix: plumbing reaction will not use power when emptying or when there are no reagents to heat fix: you can hit the chem reaction chamber with items like beakers, screwdrivers, crowbars and what not /:cl: * Plumbing & chem reaction chamber patches --------- Co-authored-by: SyncIt21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1155
Original PR: tgstation/tgstation#81473
About The Pull Request
Builds upon the changes in tgstation/tgstation#81477
1. Qol
2. Code Improvements
update_path_names(),get_requested_amt()etc into their required places to reduce proc callsadd_cable(),add_glass()etc. makes them privateChangelog
🆑 SyncIt21
qol: adds examines & screentips for building & deconstructing both machine & computer frames.
qol: Adding a circuitboard from a rped to n computer frame will automatically screw it in place like before.
code: merged procs for computer & machine frames. autodocs them where possible.
code: moved code for machine frame into its own file.
/:cl: